From mboxrd@z Thu Jan 1 00:00:00 1970 From: Darrick J. Wong Date: Wed, 26 Jun 2019 08:30:36 -0700 Subject: [Cluster-devel] [PATCH 1/5] vfs: create a generic checking and prep function for FS_IOC_SETFLAGS In-Reply-To: <20190626040202.GA32272@ZenIV.linux.org.uk> References: <156151632209.2283456.3592379873620132456.stgit@magnolia> <156151633004.2283456.4175543089138173586.stgit@magnolia> <20190626040202.GA32272@ZenIV.linux.org.uk> Message-ID: <20190626153036.GD5171@magnolia> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Wed, Jun 26, 2019 at 05:02:02AM +0100, Al Viro wrote: > On Tue, Jun 25, 2019 at 07:32:10PM -0700, Darrick J. Wong wrote: > > From: Darrick J. Wong > > > > Create a generic function to check incoming FS_IOC_SETFLAGS flag values > > and later prepare the inode for updates so that we can standardize the > > implementations that follow ext4's flag values. > > Change in efivarfs behaviour deserves a note. I'm not saying it's wrong, > but behaviour is changed there - no-op FS_IOC_SETFLAGS used to fail > without CAP_LINUX_IMMUTABLE... Ok, will do. FWIW I wondered about fixing the orangefs usage too (using an unsigned long uval to hold the contents of an unsigned int coming from userspace) but ... that's their decision. --D