[Cluster-devel] [gfs2:gfs2-iopen 15/15] fs/gfs2/glock.c:687:6: sparse: sparse: symbol '__gfs2_inode_remember_delete' was not declared. Should it be static?

[Cluster-devel] [gfs2:gfs2-iopen 15/15] fs/gfs2/glock.c:687:6: sparse: sparse: symbol '__gfs2_inode_remember_delete' was not declared. Should it be static?

[kbuild test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git gfs2-iopen
head:   90a0918fc357b78974088d4dc80de1448d8f135a
commit: 90a0918fc357b78974088d4dc80de1448d8f135a [15/15] DEBUG
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.1-153-g47b6dfef-dirty
        git checkout 90a0918fc357b78974088d4dc80de1448d8f135a
        make ARCH=x86_64 allmodconfig
        make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)

>> fs/gfs2/glock.c:687:6: sparse: sparse: symbol '__gfs2_inode_remember_delete' was not declared. Should it be static?
   fs/gfs2/glock.h:172:36: sparse: sparse: context imbalance in '__gfs2_glock_put' - unexpected unlock
   arch/x86/include/asm/bitops.h:77:37: sparse: sparse: cast truncates bits from constant value (ffffff7f becomes 7f)
   arch/x86/include/asm/bitops.h:77:37: sparse: sparse: cast truncates bits from constant value (ffffff7f becomes 7f)
   fs/gfs2/glock.c:834:13: sparse: sparse: context imbalance in 'glock_work_func' - different lock contexts for basic block

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all at lists.01.org Intel Corporation

[Cluster-devel] [RFC PATCH gfs2] __gfs2_inode_remember_delete() can be static

[kbuild test robot]

Fixes: 90a0918fc357 ("DEBUG")
Signed-off-by: kbuild test robot <lkp@intel.com>
---
 glock.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c
index b0d5c98f476eb..75524557c96f4 100644
--- a/fs/gfs2/glock.c
+++ b/fs/gfs2/glock.c
@@ -684,7 +684,7 @@ __acquires(&gl->gl_lockref.lock)
 	return;
 }
 
-void __gfs2_inode_remember_delete(struct gfs2_glock *gl, u64 generation)
+static void __gfs2_inode_remember_delete(struct gfs2_glock *gl, u64 generation)
 {
 	struct gfs2_inode_lvb *ri = (void *)gl->gl_lksb.sb_lvbptr;