From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Date: Mon, 10 Feb 2020 15:29:42 -0800 Subject: [Cluster-devel] [PATCH 01/12] mm: fix a comment in sys_swapon In-Reply-To: <20200114161225.309792-2-hch@lst.de> References: <20200114161225.309792-1-hch@lst.de> <20200114161225.309792-2-hch@lst.de> Message-ID: <20200210152942.2ec4d0b71851feccb7387266@linux-foundation.org> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Tue, 14 Jan 2020 17:12:14 +0100 Christoph Hellwig wrote: > claim_swapfile now always takes i_rwsem. > > ... > > --- a/mm/swapfile.c > +++ b/mm/swapfile.c > @@ -3157,7 +3157,7 @@ SYSCALL_DEFINE2(swapon, const char __user *, specialfile, int, swap_flags) > mapping = swap_file->f_mapping; > inode = mapping->host; > > - /* If S_ISREG(inode->i_mode) will do inode_lock(inode); */ > + /* will take i_rwsem; */ > error = claim_swapfile(p, inode); > if (unlikely(error)) > goto bad_swap; http://lkml.kernel.org/r/20200206090132.154869-1-naohiro.aota at wdc.com removes this comment altogether. Please check that this is OK?