From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Date: Mon, 24 Feb 2020 13:32:20 -0800 Subject: [Cluster-devel] [PATCH v7 01/24] mm: Move readahead prototypes from mm.h In-Reply-To: <20200219210103.32400-2-willy@infradead.org> References: <20200219210103.32400-1-willy@infradead.org> <20200219210103.32400-2-willy@infradead.org> Message-ID: <20200224213220.GA13895@infradead.org> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Wed, Feb 19, 2020 at 01:00:40PM -0800, Matthew Wilcox wrote: > From: "Matthew Wilcox (Oracle)" > > The readahead code is part of the page cache so should be found in the > pagemap.h file. force_page_cache_readahead is only used within mm, > so move it to mm/internal.h instead. Remove the parameter names where > they add no value, and rename the ones which were actively misleading. Looks good, Reviewed-by: Christoph Hellwig