From: Alexander Aring <aahringo@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH dlm-tool 2/4] dlm_controld: fix may be used uninitialized
Date: Tue, 14 Jul 2020 14:01:14 -0400 [thread overview]
Message-ID: <20200714180116.18642-3-aahringo@redhat.com> (raw)
In-Reply-To: <20200714180116.18642-1-aahringo@redhat.com>
This patch fixes the following compiler warning:
daemon_cpg.c:2158:12: warning: ?run? may be used uninitialized in this function [-Wmaybe-uninitialized]
2158 | run->info.reply_count++;
It's fixed by just init the used variable to NULL and use it only if
it's not NULL.
---
dlm_controld/daemon_cpg.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/dlm_controld/daemon_cpg.c b/dlm_controld/daemon_cpg.c
index 99aca8db..392e0ff6 100644
--- a/dlm_controld/daemon_cpg.c
+++ b/dlm_controld/daemon_cpg.c
@@ -2115,7 +2115,7 @@ int receive_run_reply(struct dlm_header *hd, int len)
int receive_run_request(struct dlm_header *hd, int len)
{
struct run_request *req = (struct run_request *)hd;
- struct run *run;
+ struct run *run = NULL;
run_request_in(req);
@@ -2153,7 +2153,7 @@ int receive_run_request(struct dlm_header *hd, int len)
return 0;
}
- if (!opt(enable_helper_ind)) {
+ if (!opt(enable_helper_ind) && run) {
log_debug("receive_run_request %s helper not enabled", req->uuid);
run->info.reply_count++;
run->info.need_replies--;
--
2.26.2
next prev parent reply other threads:[~2020-07-14 18:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-14 18:01 [Cluster-devel] [PATCH dlm-tool 0/4] dlm_controld: gcc-10 compile warning fixes Alexander Aring
2020-07-14 18:01 ` [Cluster-devel] [PATCH dlm-tool 1/4] dlm_controld: fix -Wstringop-truncation warnings Alexander Aring
2020-07-14 18:01 ` Alexander Aring [this message]
2020-07-14 18:01 ` [Cluster-devel] [PATCH dlm-tool 3/4] dlm_controld: fix may be used uninitialized Alexander Aring
2020-07-14 18:01 ` [Cluster-devel] [PATCH dlm-tool 4/4] dlm_controld: get notice about failed config parse Alexander Aring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200714180116.18642-3-aahringo@redhat.com \
--to=aahringo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).