From: Abhi Das <adas@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 1/3] gfs2: Don't write updates to local statfs file
Date: Thu, 13 Aug 2020 15:01:12 -0500 [thread overview]
Message-ID: <20200813200114.5665-2-adas@redhat.com> (raw)
In-Reply-To: <20200813200114.5665-1-adas@redhat.com>
We store the local statfs info in the journal header now so
there's no need to write to the local statfs file anymore.
Signed-off-by: Abhi Das <adas@redhat.com>
---
fs/gfs2/lops.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/fs/gfs2/lops.c b/fs/gfs2/lops.c
index cb2a11b458c6..53d2dbf6605e 100644
--- a/fs/gfs2/lops.c
+++ b/fs/gfs2/lops.c
@@ -104,7 +104,15 @@ static void gfs2_unpin(struct gfs2_sbd *sdp, struct buffer_head *bh,
BUG_ON(!buffer_pinned(bh));
lock_buffer(bh);
- mark_buffer_dirty(bh);
+ /*
+ * We want to eliminate the local statfs file eventually.
+ * But, for now, we're simply not going to update it by
+ * never marking its buffers dirty
+ */
+ if (!(bd->bd_gl->gl_name.ln_type == LM_TYPE_INODE &&
+ bd->bd_gl->gl_object == GFS2_I(sdp->sd_sc_inode)))
+ mark_buffer_dirty(bh);
+
clear_buffer_pinned(bh);
if (buffer_is_rgrp(bd))
--
2.20.1
next prev parent reply other threads:[~2020-08-13 20:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-13 20:01 [Cluster-devel] [PATCH 0/3] local statfs improvements Abhi Das
2020-08-13 20:01 ` Abhi Das [this message]
2020-08-19 17:07 ` [Cluster-devel] [PATCH 1/3] gfs2: Don't write updates to local statfs file Bob Peterson
2020-08-20 11:04 ` Abhijith Das
2020-08-20 11:23 ` Steven Whitehouse
2020-08-13 20:01 ` [Cluster-devel] [PATCH 2/3] gfs2: Add fields for statfs info in struct gfs2_log_header_host Abhi Das
2020-08-13 20:01 ` [Cluster-devel] [PATCH 3/3] gfs2: Recover statfs info in journal head Abhi Das
2020-08-19 17:27 ` Bob Peterson
2020-08-20 11:07 ` Abhijith Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200813200114.5665-2-adas@redhat.com \
--to=adas@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).