From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Date: Mon, 7 Sep 2020 08:07:01 +0100 Subject: [Cluster-devel] [PATCH] iomap: Fix direct I/O write consistency check In-Reply-To: <20200903165632.1338996-1-agruenba@redhat.com> References: <20200903165632.1338996-1-agruenba@redhat.com> Message-ID: <20200907070701.GA27019@infradead.org> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Thu, Sep 03, 2020 at 06:56:32PM +0200, Andreas Gruenbacher wrote: > When a direct I/O write falls back to buffered I/O entirely, dio->size > will be 0 in iomap_dio_complete. Function invalidate_inode_pages2_range > will try to invalidate the rest of the address space. If there are any > dirty pages in that range, the write will fail and a "Page cache > invalidation failure on direct I/O" error will be logged. Looks good, Reviewed-by: Christoph Hellwig