cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Alexander Aring <aahringo@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH dlm/next 7/9] fs: dlm: move shutdown action to node creation
Date: Mon, 19 Oct 2020 14:59:14 -0400	[thread overview]
Message-ID: <20201019185916.707827-8-aahringo@redhat.com> (raw)
In-Reply-To: <20201019185916.707827-1-aahringo@redhat.com>

This patch move the assignment for the shutdown action callback to the
node creation functionality.

Signed-off-by: Alexander Aring <aahringo@redhat.com>
---
 fs/dlm/lowcomms.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/fs/dlm/lowcomms.c b/fs/dlm/lowcomms.c
index e8657ae023654..bae4125c22deb 100644
--- a/fs/dlm/lowcomms.c
+++ b/fs/dlm/lowcomms.c
@@ -144,6 +144,7 @@ static void process_send_sockets(struct work_struct *work);
 
 static void sctp_connect_to_sock(struct connection *con);
 static void tcp_connect_to_sock(struct connection *con);
+static void dlm_tcp_shutdown(struct connection *con);
 
 /* This is deliberately very simple because most clusters have simple
    sequential nodeids, so we should be able to go straight to a connection
@@ -212,10 +213,12 @@ static struct connection *nodeid2con(int nodeid, gfp_t alloc)
 			con->rx_action = zerocon->rx_action;
 	}
 
-	if (dlm_config.ci_protocol == 0)
+	if (dlm_config.ci_protocol == 0) {
 		con->connect_action = tcp_connect_to_sock;
-	else
+		con->shutdown_action = dlm_tcp_shutdown;
+	} else {
 		con->connect_action = sctp_connect_to_sock;
+	}
 
 	r = nodeid_hash(nodeid);
 
@@ -1112,7 +1115,6 @@ static void tcp_connect_to_sock(struct connection *con)
 	}
 
 	con->rx_action = receive_from_sock;
-	con->shutdown_action = dlm_tcp_shutdown;
 	add_sock(sock, con);
 
 	/* Bind to our cluster-known address connecting to avoid
-- 
2.26.2



  parent reply	other threads:[~2020-10-19 18:59 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-19 18:59 [Cluster-devel] [PATCH dlm/next 0/9] fs: dlm: fixes and change listen socket handling Alexander Aring
2020-10-19 18:59 ` [Cluster-devel] [PATCH dlm/next 1/9] fs: dlm: fix proper srcu api call Alexander Aring
2020-10-19 18:59 ` [Cluster-devel] [PATCH dlm/next 2/9] fs: dlm: define max send buffer Alexander Aring
2020-10-19 18:59 ` [Cluster-devel] [PATCH dlm/next 3/9] fs: dlm: add get buffer error handling Alexander Aring
2020-10-19 18:59 ` [Cluster-devel] [PATCH dlm/next 4/9] fs: dlm: flush othercon at close Alexander Aring
2020-10-19 18:59 ` [Cluster-devel] [PATCH dlm/next 5/9] fs: dlm: handle non blocked connect event Alexander Aring
2020-10-19 18:59 ` [Cluster-devel] [PATCH dlm/next 6/9] fs: dlm: move connect callback in node creation Alexander Aring
2020-10-19 18:59 ` Alexander Aring [this message]
2020-10-19 18:59 ` [Cluster-devel] [PATCH dlm/next 8/9] fs: dlm: refactor sctp sock parameter Alexander Aring
2020-10-19 18:59 ` [Cluster-devel] [PATCH dlm/next 9/9] fs: dlm: listen socket out of connection hash Alexander Aring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201019185916.707827-8-aahringo@redhat.com \
    --to=aahringo@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).