From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Aring Date: Tue, 1 Dec 2020 10:09:40 -0500 Subject: [Cluster-devel] [PATCHv2 dlm/next 00/17] fs: dlm: introduce dlm re-transmission layer Message-ID: <20201201150957.115068-1-aahringo@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Hi, this is the final patch-series to make dlm reliable when re-connection occurs. You can easily generate a couple of re-connections by running: tcpkill -9 -i $IFACE port 21064 on your own to test these patches. At some time dlm will detect message drops and will re-transmit messages if necessary. It introduces a new dlm protocol behaviour and increases the dlm protocol version. I tested it with SCTP as well and tried to be backwards compatible with dlm protocol version 3.1. However I don't recommend at all to not mix these versions in a setup since dlm version 3.2 fixes long-term issues. - Alex changes since v2: - add patch "fs: dlm: set connected bit after accept" - add patch "fs: dlm: set subclass for othercon sock_mutex" - change title "fs: dlm: public utils header utils" to "fs: dlm: public header in out utility" - squash "fs: dlm: add check for minimum allocation length" into "fs: dlm: remove unaligned memory access handling" - make the midcomms timeout a little bit longer, because I saw sometimes it's not enough (I hope that was the reason) - midcomms: fix version mismatch handling - remove DLM_ACK in invalid sequence handling - add additional length check in dlm_opts_check_msglen() - use optlen to skip DLM_OPTS header - add DLM_MSGLEN_IS_NOT_ALIGNED to check if msglen is proper aligned before parsing - change dlm_midcomms_close() to close first then cut queues, because lowcomms close will may flush some messages which need to be dropped afterwards if seq doesn't fit. - remove newline in "fs: dlm: add more midcomms hooks" - may more changes which I don't have on track. - change defines handling for calculating max application buffer size vs max allocation size - run aspell on my commit msgs Alexander Aring (17): fs: dlm: set connected bit after accept fs: dlm: set subclass for othercon sock_mutex fs: dlm: add errno handling to check callback fs: dlm: add check if dlm is currently running fs: dlm: change allocation limits fs: dlm: public header in out utility fs: dlm: use GFP_ZERO for page buffer fs: dlm: simplify writequeue handling fs: dlm: add more midcomms hooks fs: dlm: make buffer handling per msg fs: dlm: make new buffer handling softirq ready fs: dlm: add functionality to re-transmit a message fs: dlm: move out some hash functionality fs: dlm: remove unaligned memory access handling fs: dlm: add union in dlm header for lockspace id fs: dlm: add reliable connection if reconnect fs: dlm: don't allow half transmitted messages fs/dlm/config.c | 60 ++- fs/dlm/dlm_internal.h | 32 +- fs/dlm/lock.c | 16 +- fs/dlm/lockspace.c | 5 +- fs/dlm/lowcomms.c | 279 ++++++++--- fs/dlm/lowcomms.h | 26 +- fs/dlm/member.c | 16 + fs/dlm/member.h | 1 + fs/dlm/midcomms.c | 1098 +++++++++++++++++++++++++++++++++++++++-- fs/dlm/midcomms.h | 10 + fs/dlm/rcom.c | 61 ++- fs/dlm/recoverd.c | 3 + fs/dlm/util.c | 10 +- fs/dlm/util.h | 2 + 14 files changed, 1445 insertions(+), 174 deletions(-) -- 2.26.2