From: Bob Peterson <rpeterso@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [GFS2 v2 PATCH 0/2] Circular lock dependency on unmount
Date: Tue, 22 Dec 2020 14:43:26 -0600 [thread overview]
Message-ID: <20201222204328.78528-1-rpeterso@redhat.com> (raw)
Version 2 implements Andreas's suggestions.
This patch set fixes a circular lock dependency flagged by LOCKDEP when a
gfs2 file system is unmounted. The first patch adds new helper functions
for holding and releasing the freeze glock. Functionality should be the same.
The second patch moves the freeze locks that used to be inside the
make_fs_ro and _rw functions to their callers. The unmount caller, however,
is exempted to avoid the lock dependency. The change means that function
init_threads is now called from within the freeze lock, but that should
not matter.
Bob Peterson (2):
gfs2: Add common helper for holding and releasing the freeze glock
gfs2: move freeze glock outside the make_fs_rw and _ro functions
fs/gfs2/ops_fstype.c | 33 ++++++++++++++++----------------
fs/gfs2/recovery.c | 8 +++-----
fs/gfs2/super.c | 45 ++++----------------------------------------
fs/gfs2/util.c | 43 ++++++++++++++++++++++++++++++++++++++++--
fs/gfs2/util.h | 3 +++
5 files changed, 68 insertions(+), 64 deletions(-)
--
2.29.2
next reply other threads:[~2020-12-22 20:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-22 20:43 Bob Peterson [this message]
2020-12-22 20:43 ` [Cluster-devel] [GFS2 PATCH 1/2] gfs2: Add common helper for holding and releasing the freeze glock Bob Peterson
2020-12-22 20:43 ` [Cluster-devel] [GFS2 PATCH 2/2] gfs2: move freeze glock outside the make_fs_rw and _ro functions Bob Peterson
2020-12-22 23:58 ` Andreas Gruenbacher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201222204328.78528-1-rpeterso@redhat.com \
--to=rpeterso@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).