From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bob Peterson Date: Tue, 22 Dec 2020 14:43:26 -0600 Subject: [Cluster-devel] [GFS2 v2 PATCH 0/2] Circular lock dependency on unmount Message-ID: <20201222204328.78528-1-rpeterso@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Version 2 implements Andreas's suggestions. This patch set fixes a circular lock dependency flagged by LOCKDEP when a gfs2 file system is unmounted. The first patch adds new helper functions for holding and releasing the freeze glock. Functionality should be the same. The second patch moves the freeze locks that used to be inside the make_fs_ro and _rw functions to their callers. The unmount caller, however, is exempted to avoid the lock dependency. The change means that function init_threads is now called from within the freeze lock, but that should not matter. Bob Peterson (2): gfs2: Add common helper for holding and releasing the freeze glock gfs2: move freeze glock outside the make_fs_rw and _ro functions fs/gfs2/ops_fstype.c | 33 ++++++++++++++++---------------- fs/gfs2/recovery.c | 8 +++----- fs/gfs2/super.c | 45 ++++---------------------------------------- fs/gfs2/util.c | 43 ++++++++++++++++++++++++++++++++++++++++-- fs/gfs2/util.h | 3 +++ 5 files changed, 68 insertions(+), 64 deletions(-) -- 2.29.2