From: Lee Jones <lee.jones@linaro.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 05/18] fs: gfs2: log: Fix a couple of param descriptions and demote non-conformant headers
Date: Fri, 26 Mar 2021 09:11:38 +0000 [thread overview]
Message-ID: <20210326091151.311647-6-lee.jones@linaro.org> (raw)
In-Reply-To: <20210326091151.311647-1-lee.jones@linaro.org>
Fixes the following W=1 kernel build warning(s):
fs/gfs2/log.c:76: warning: Excess function parameter 'mapping' description in 'gfs2_remove_from_ail'
fs/gfs2/log.c:97: warning: Function parameter or member 'tr' not described in 'gfs2_ail1_start_one'
fs/gfs2/log.c:97: warning: Function parameter or member 'plug' not described in 'gfs2_ail1_start_one'
fs/gfs2/log.c:97: warning: Excess function parameter 'ai' description in 'gfs2_ail1_start_one'
fs/gfs2/log.c:278: warning: Function parameter or member 'sdp' not described in 'gfs2_ail_empty_tr'
fs/gfs2/log.c:278: warning: Function parameter or member 'tr' not described in 'gfs2_ail_empty_tr'
fs/gfs2/log.c:278: warning: Function parameter or member 'head' not described in 'gfs2_ail_empty_tr'
fs/gfs2/log.c:1174: warning: Function parameter or member 'sdp' not described in 'gfs2_merge_trans'
fs/gfs2/log.c:1174: warning: Excess function parameter 'old' description in 'gfs2_merge_trans'
fs/gfs2/log.c:1293: warning: Function parameter or member 'data' not described in 'gfs2_logd'
fs/gfs2/log.c:1293: warning: Excess function parameter 'sdp' description in 'gfs2_logd'
Cc: Bob Peterson <rpeterso@redhat.com>
Cc: Andreas Gruenbacher <agruenba@redhat.com>
Cc: cluster-devel at redhat.com
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
fs/gfs2/log.c | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/fs/gfs2/log.c b/fs/gfs2/log.c
index 6410281546f92..eef33cd251e4b 100644
--- a/fs/gfs2/log.c
+++ b/fs/gfs2/log.c
@@ -65,7 +65,6 @@ unsigned int gfs2_struct2blk(struct gfs2_sbd *sdp, unsigned int nstruct)
/**
* gfs2_remove_from_ail - Remove an entry from the ail lists, updating counters
- * @mapping: The associated mapping (maybe NULL)
* @bd: The gfs2_bufdata to remove
*
* The ail lock _must_ be held when calling this function
@@ -81,12 +80,10 @@ void gfs2_remove_from_ail(struct gfs2_bufdata *bd)
brelse(bd->bd_bh);
}
-/**
+/*
* gfs2_ail1_start_one - Start I/O on a part of the AIL
* @sdp: the filesystem
* @wbc: The writeback control structure
- * @ai: The ail structure
- *
*/
static int gfs2_ail1_start_one(struct gfs2_sbd *sdp,
@@ -269,7 +266,7 @@ static void gfs2_log_update_head(struct gfs2_sbd *sdp)
sdp->sd_log_head = new_head;
}
-/**
+/*
* gfs2_ail_empty_tr - empty one of the ail lists of a transaction
*/
@@ -1166,7 +1163,7 @@ void gfs2_log_flush(struct gfs2_sbd *sdp, struct gfs2_glock *gl, u32 flags)
/**
* gfs2_merge_trans - Merge a new transaction into a cached transaction
- * @old: Original transaction to be expanded
+ * @sdp: the filesystem
* @new: New transaction to be merged
*/
@@ -1283,7 +1280,7 @@ static inline int gfs2_ail_flush_reqd(struct gfs2_sbd *sdp)
/**
* gfs2_logd - Update log tail as Active Items get flushed to in-place blocks
- * @sdp: Pointer to GFS2 superblock
+ * @data: Pointer to GFS2 superblock
*
* Also, periodically check to make sure that we're using the most recent
* journal index.
--
2.27.0
next prev parent reply other threads:[~2021-03-26 9:11 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-26 9:11 [Cluster-devel] [PATCH 00/18] Rid W=1 warnings from GFS2 Lee Jones
2021-03-26 9:11 ` [Cluster-devel] [PATCH 01/18] fs: gfs2: dir: Finish off mostly complete headers demote others Lee Jones
2021-03-26 9:11 ` [Cluster-devel] [PATCH 02/18] fs: gfs2: xattr: Help out some kernel-doc header demote non-conformant ones Lee Jones
2021-03-26 9:11 ` [Cluster-devel] [PATCH 03/18] fs: gfs2: bmap: Demote half-complete kernel-doc headers fix others Lee Jones
2021-03-26 9:11 ` [Cluster-devel] [PATCH 04/18] fs: gfs2: glops: Fix a couple of kernel-doc misdemeanours demote others Lee Jones
2021-03-26 9:11 ` Lee Jones [this message]
2021-03-26 9:11 ` [Cluster-devel] [PATCH 06/18] fs: gfs2: lops: Help out worthy kernel-doc headers and " Lee Jones
2021-03-26 9:11 ` [Cluster-devel] [PATCH 07/18] fs: gfs2: glock: Fix some deficient kernel-doc headers and demote non-conformant ones Lee Jones
2021-03-26 9:11 ` [Cluster-devel] [PATCH 08/18] fs: gfs2: aops: Fix a little potential doc-rot Lee Jones
2021-03-26 9:11 ` [Cluster-devel] [PATCH 09/18] fs: gfs2: meta_io: Add missing description for 'rahead' param Lee Jones
2021-03-26 9:11 ` [Cluster-devel] [PATCH 10/18] fs: gfs2: inode: Fix worthy function headers demote others Lee Jones
2021-03-26 9:11 ` [Cluster-devel] [PATCH 11/18] fs: gfs2: file: Strip out superflouous param description and demote kernel-doc abuse Lee Jones
2021-03-26 9:11 ` [Cluster-devel] [PATCH 12/18] fs: gfs2: ops_fstype: Fix a little doc-rot Lee Jones
2021-03-26 9:11 ` [Cluster-devel] [PATCH 13/18] fs: gfs2: quota: Fix incorrect param name in 'gfs2_quotad' Lee Jones
2021-03-26 9:11 ` [Cluster-devel] [PATCH 14/18] fs: gfs2: rgrp: Fix a few kernel-doc misdemeanours Lee Jones
2021-03-26 9:11 ` [Cluster-devel] [PATCH 15/18] fs: gfs2: recovery: Provide missing param descriptions and remove one other Lee Jones
2021-03-26 9:11 ` [Cluster-devel] [PATCH 16/18] fs: gfs2: super: Fix kernel-doc issues where feasible demote " Lee Jones
2021-03-26 9:11 ` [Cluster-devel] [PATCH 17/18] fs: gfs2: util: Fix one conformant kernel-doc header and demote a bunch of abuses Lee Jones
2021-03-26 9:11 ` [Cluster-devel] [PATCH 18/18] fs: gfs2: lock_dlm: Demote incomplete kernel-doc header Lee Jones
2021-04-06 9:11 ` [Cluster-devel] [PATCH 00/18] Rid W=1 warnings from GFS2 Lee Jones
2021-04-06 11:44 ` Bob Peterson
2021-04-06 11:54 ` Lee Jones
2021-04-09 20:35 ` Andreas Gruenbacher
2021-04-12 7:37 ` Lee Jones
2021-04-06 13:43 ` [Cluster-devel] Unsubscribe from list Andreas Schindler
2021-04-06 15:25 ` Andreas Gruenbacher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210326091151.311647-6-lee.jones@linaro.org \
--to=lee.jones@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).