From: Alexander Aring <aahringo@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCHv3 dlm/next 0/8] fs: dlm: introduce dlm re-transmission layer
Date: Fri, 26 Mar 2021 13:33:29 -0400 [thread overview]
Message-ID: <20210326173337.44231-1-aahringo@redhat.com> (raw)
Hi,
this is the final patch-series to make dlm reliable when re-connection
occurs. You can easily generate a couple of re-connections by running:
tcpkill -9 -i $IFACE port 21064
on your own to test these patches. At some time dlm will detect message
drops and will re-transmit messages if necessary. It introduces a new dlm
protocol behaviour and increases the dlm protocol version. I tested it
with SCTP as well and tried to be backwards compatible with dlm protocol
version 3.1. However I don't recommend at all to mix these versions
in a setup since dlm version 3.2 fixes long-term issues.
- Alex
changes since v3:
- add comment about why queues are unbound
- move rcu usage to version receive handler
changes since v2:
- make timer handling pending only if messages are on air, the sync
isn't quite correct there but doesn't need to be precise
- use before() from tcp to check if seq is before other seq with
respect of overflows
- change srcu handling to hold srcu in all places where nodes are
referencing - we should not get a disadvantage of holding that
lock. We should update also lowcomms regarding to that.
- add some WARN_ON() to check that nothing in send/recv is going
anymore otherwise it's likely an issue.
- add more future work regarding to fencing of nodes if over
cluster manager timeout/bad seq happens
- add note about missing length size check of tail payload
(resource name length) regarding to the receive buffer
- remove some include which isn't necessary in recoverd.c
Thanks to Paolo Abeni for his review and recommendations.
Alexander Aring (8):
fs: dlm: public header in out utility
fs: dlm: add more midcomms hooks
fs: dlm: make buffer handling per msg
fs: dlm: add functionality to re-transmit a message
fs: dlm: move out some hash functionality
fs: dlm: add union in dlm header for lockspace id
fs: dlm: add reliable connection if reconnect
fs: dlm: don't allow half transmitted messages
fs/dlm/config.c | 3 +-
fs/dlm/dlm_internal.h | 35 +-
fs/dlm/lock.c | 14 +-
fs/dlm/lockspace.c | 14 +-
fs/dlm/lowcomms.c | 197 +++++--
fs/dlm/lowcomms.h | 23 +-
fs/dlm/member.c | 12 +-
fs/dlm/midcomms.c | 1307 ++++++++++++++++++++++++++++++++++++++++-
fs/dlm/midcomms.h | 10 +
fs/dlm/rcom.c | 63 +-
fs/dlm/util.c | 10 +-
fs/dlm/util.h | 2 +
12 files changed, 1577 insertions(+), 113 deletions(-)
--
2.26.3
next reply other threads:[~2021-03-26 17:33 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-26 17:33 Alexander Aring [this message]
2021-03-26 17:33 ` [Cluster-devel] [PATCHv3 dlm/next 1/8] fs: dlm: public header in out utility Alexander Aring
2021-03-26 17:33 ` [Cluster-devel] [PATCHv3 dlm/next 2/8] fs: dlm: add more midcomms hooks Alexander Aring
2021-03-26 17:33 ` [Cluster-devel] [PATCHv3 dlm/next 3/8] fs: dlm: make buffer handling per msg Alexander Aring
2021-03-26 17:33 ` [Cluster-devel] [PATCHv3 dlm/next 4/8] fs: dlm: add functionality to re-transmit a message Alexander Aring
2021-03-26 17:33 ` [Cluster-devel] [PATCHv3 dlm/next 5/8] fs: dlm: move out some hash functionality Alexander Aring
2021-03-26 17:33 ` [Cluster-devel] [PATCHv3 dlm/next 6/8] fs: dlm: add union in dlm header for lockspace id Alexander Aring
2021-03-26 17:33 ` [Cluster-devel] [PATCHv3 dlm/next 7/8] fs: dlm: add reliable connection if reconnect Alexander Aring
2021-04-02 20:53 ` Guillaume Nault
2021-04-03 15:34 ` Alexander Ahring Oder Aring
2021-04-05 17:33 ` Alexander Ahring Oder Aring
2021-04-05 20:29 ` Alexander Ahring Oder Aring
2021-04-09 21:11 ` Guillaume Nault
2021-04-12 15:35 ` Alexander Ahring Oder Aring
2021-04-09 20:44 ` Guillaume Nault
2021-04-12 15:30 ` Alexander Ahring Oder Aring
2021-04-12 15:42 ` Alexander Ahring Oder Aring
2021-04-09 20:32 ` Guillaume Nault
2021-04-12 15:21 ` Alexander Ahring Oder Aring
2021-04-21 16:21 ` Alexander Ahring Oder Aring
2021-03-26 17:33 ` [Cluster-devel] [PATCHv3 dlm/next 8/8] fs: dlm: don't allow half transmitted messages Alexander Aring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210326173337.44231-1-aahringo@redhat.com \
--to=aahringo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).