[Cluster-devel] [gfs2:for-next.radical8h 22/30] fs/gfs2/glock.c:572:1: warning: unused label 'out'

[Cluster-devel] [gfs2:for-next.radical8h 22/30] fs/gfs2/glock.c:572:1: warning: unused label 'out'

[kernel test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git for-next.radical8h
head:   3c95769f71be56000ea9bd18703ed6cd5f8f5181
commit: cdf7a5eaeeba5ae3833e339d1de6d1577fe946b5 [22/30] gfs2: Introduce new GL_ST_XMOTE_DENIED state
config: x86_64-randconfig-a004-20210428 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 87fc97169e7901dfe56ca0da0d92da0c02d2ef48)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git/commit/?id=cdf7a5eaeeba5ae3833e339d1de6d1577fe946b5
        git remote add gfs2 https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git
        git fetch --no-tags gfs2 for-next.radical8h
        git checkout cdf7a5eaeeba5ae3833e339d1de6d1577fe946b5
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   In file included from fs/gfs2/glock.c:39:
   fs/gfs2/glock.h:208:15: warning: 'const' type qualifier on return type has no effect [-Wignored-qualifiers]
   static inline const int gl_mode(const struct gfs2_glock *gl)
                 ^~~~~~
   In file included from fs/gfs2/glock.c:49:
   fs/gfs2/trace_gfs2.h:65:15: warning: 'const' type qualifier on return type has no effect [-Wignored-qualifiers]
   static inline const u8 glock_trace_mode(const unsigned int mode)
                 ^~~~~~
>> fs/gfs2/glock.c:572:1: warning: unused label 'out' [-Wunused-label]
   out:
   ^~~~
   fs/gfs2/glock.c:557:6: warning: unused variable 'rv' [-Wunused-variable]
           int rv;
               ^
   fs/gfs2/glock.c:554:38: warning: unused variable 'glops' [-Wunused-variable]
           const struct gfs2_glock_operations *glops = gl->gl_ops;
                                               ^
   5 warnings generated.


vim +/out +572 fs/gfs2/glock.c

cdf7a5eaeeba5a Bob Peterson      2021-04-23  545  
cdf7a5eaeeba5a Bob Peterson      2021-04-23  546  /**
cdf7a5eaeeba5a Bob Peterson      2021-04-23  547   * state_finish_xmote - The lock manager replied to one of our lock requests
cdf7a5eaeeba5a Bob Peterson      2021-04-23  548   * @gl: The glock
cdf7a5eaeeba5a Bob Peterson      2021-04-23  549   *
cdf7a5eaeeba5a Bob Peterson      2021-04-23  550   */
cdf7a5eaeeba5a Bob Peterson      2021-04-23  551  
cdf7a5eaeeba5a Bob Peterson      2021-04-23  552  static noinline void state_finish_xmote(struct gfs2_glock *gl)
cdf7a5eaeeba5a Bob Peterson      2021-04-23  553  {
cdf7a5eaeeba5a Bob Peterson      2021-04-23  554  	const struct gfs2_glock_operations *glops = gl->gl_ops;
cdf7a5eaeeba5a Bob Peterson      2021-04-23  555  	int ret = gl->gl_reply;
cdf7a5eaeeba5a Bob Peterson      2021-04-23  556  	unsigned mode = ret & LM_OUT_ST_MASK;
cdf7a5eaeeba5a Bob Peterson      2021-04-23  557  	int rv;
cdf7a5eaeeba5a Bob Peterson      2021-04-23  558  
cdf7a5eaeeba5a Bob Peterson      2021-04-23  559  	/* Check for dlm mode != requested mode */
cdf7a5eaeeba5a Bob Peterson      2021-04-23  560  	if (unlikely(mode != gl->gl_req)) {
cdf7a5eaeeba5a Bob Peterson      2021-04-23  561  		next_state(gl, GL_ST_XMOTE_DENIED);
cdf7a5eaeeba5a Bob Peterson      2021-04-23  562  		return;
6802e3400ff454 Steven Whitehouse 2008-05-21  563  	}
6802e3400ff454 Steven Whitehouse 2008-05-21  564  
6802e3400ff454 Steven Whitehouse 2008-05-21  565  	/* Fast path - we got what we asked for */
6802e3400ff454 Steven Whitehouse 2008-05-21  566  	if (test_and_clear_bit(GLF_DEMOTE_IN_PROGRESS, &gl->gl_flags))
6802e3400ff454 Steven Whitehouse 2008-05-21  567  		gfs2_demote_wake(gl);
37eabf9ca6285b Bob Peterson      2021-04-21  568  	if (mode != LM_ST_UNLOCKED) {
32e1ca803a1757 Bob Peterson      2021-04-23  569  		next_state(gl, GL_ST_PROMOTE);
9756705add3bc4 Bob Peterson      2020-12-08  570  		return;
6802e3400ff454 Steven Whitehouse 2008-05-21  571  	}
6802e3400ff454 Steven Whitehouse 2008-05-21 @572  out:
6802e3400ff454 Steven Whitehouse 2008-05-21  573  	clear_bit(GLF_LOCK, &gl->gl_flags);
9756705add3bc4 Bob Peterson      2020-12-08  574  }
9756705add3bc4 Bob Peterson      2020-12-08  575  

:::::: The code at line 572 was first introduced by commit
:::::: 6802e3400ff4549525930ee744030c36fce9cc73 [GFS2] Clean up the glock core

:::::: TO: Steven Whitehouse <swhiteho@redhat.com>
:::::: CC: Steven Whitehouse <swhiteho@redhat.com>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all at lists.01.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 31462 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/cluster-devel/attachments/20210428/efbde6ce/attachment.gz>