[Cluster-devel] [PATCH 00/15] Rid W=1 warnings from FS {GFS2, NTFS}

[Cluster-devel] [PATCH 00/15] Rid W=1 warnings from FS {GFS2, NTFS}

[Lee Jones]

This set is part of a larger effort attempting to clean-up W=1
kernel builds, which are currently overwhelmingly riddled with
niggly little warnings.

Lee Jones (15):
  fs: gfs2: bmap: Demote half-complete kernel-doc headers fix others
  fs: gfs2: glock: Fix some deficient kernel-doc headers and demote
    non-conformant ones
  fs: ntfs: namei: Demote non-conformant kernel-doc headers
  fs: ntfs: unistr: Add missing param descriptions for 'name{1,2}_len'
  fs: ntfs: compress: Demote a few non-conformant kernel-doc headers
  fs: ntfs: dir: Supply missing descriptions for 'start' and 'end' and
    demote other headers
  fs: ntfs: runlist: Demote non-conformant kernel-doc headers
  fs: ntfs: inode: Fix incorrect function name and demote file header
  fs: ntfs: attrib: File headers are not good candidates for kernel-doc
  fs: ntfs: aops: Demote kernel-doc abuses
  fs: ntfs: super: Provide missing description and demote non-conformant
    headers
  fs: ntfs: file: Provide missing descriptions for 'start' and 'end'
  fs: ntfs: mft: File headers to not make good candidates for kernel-doc
  fs: ntfs: compress: File headers are not good candidates for
    kernel-doc
  fs: ntfs: runlist: File headers are not good candidates for kernel-doc

 fs/gfs2/bmap.c     |  2 +-
 fs/gfs2/glock.c    |  4 ++--
 fs/ntfs/aops.c     |  8 ++++----
 fs/ntfs/attrib.c   |  2 +-
 fs/ntfs/compress.c | 12 ++++++------
 fs/ntfs/dir.c      |  7 ++++---
 fs/ntfs/file.c     |  2 ++
 fs/ntfs/inode.c    |  4 ++--
 fs/ntfs/mft.c      |  2 +-
 fs/ntfs/namei.c    |  4 ++--
 fs/ntfs/runlist.c  |  6 +++---
 fs/ntfs/super.c    |  5 +++--
 fs/ntfs/unistr.c   |  2 ++
 13 files changed, 33 insertions(+), 27 deletions(-)

Cc: Andreas Gruenbacher <agruenba@redhat.com>
Cc: Anton Altaparmakov <anton@tuxera.com>
Cc: Bob Peterson <rpeterso@redhat.com>
Cc: cluster-devel at redhat.com
Cc: linux-ntfs-dev at lists.sourceforge.net
Cc: to <linux-ntfs-dev@lists.sourceforge>
-- 
2.31.1

[Cluster-devel] [PATCH 01/15] fs: gfs2: bmap: Demote half-complete kernel-doc headers fix others

[Lee Jones]

Fixes the following W=1 kernel build warning(s):

 fs/gfs2/bmap.c:1502: warning: Function parameter or member 'rd_gh' not described in 'sweep_bh_for_rgrps'
 fs/gfs2/bmap.c:1502: warning: Excess function parameter 'rg_gh' description in 'sweep_bh_for_rgrps'
 fs/gfs2/bmap.c:1671: warning: Function parameter or member 'sdp' not described in 'find_nonnull_ptr'
 fs/gfs2/bmap.c:1671: warning: Function parameter or member 'end_list' not described in 'find_nonnull_ptr'
 fs/gfs2/bmap.c:1671: warning: Function parameter or member 'end_aligned' not described in 'find_nonnull_ptr'

Cc: Bob Peterson <rpeterso@redhat.com>
Cc: Andreas Gruenbacher <agruenba@redhat.com>
Cc: cluster-devel at redhat.com
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 fs/gfs2/bmap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/gfs2/bmap.c b/fs/gfs2/bmap.c
index 0bcf11a9987ba..edf6004b643ac 100644
--- a/fs/gfs2/bmap.c
+++ b/fs/gfs2/bmap.c
@@ -1658,7 +1658,7 @@ static bool mp_eq_to_hgt(struct metapath *mp, __u16 *list, unsigned int h)
 	return true;
 }
 
-/**
+/*
  * find_nonnull_ptr - find a non-null pointer given a metapath and height
  * @sdp: The superblock
  * @mp: starting metapath
-- 
2.31.1

[Cluster-devel] [PATCH 02/15] fs: gfs2: glock: Fix some deficient kernel-doc headers and demote non-conformant ones

[Lee Jones]

Fixes the following W=1 kernel build warning(s):

 fs/gfs2/glock.c:365: warning: Function parameter or member 'gl' not described in 'do_error'
 fs/gfs2/glock.c:365: warning: Function parameter or member 'ret' not described in 'do_error'
 fs/gfs2/glock.c:461: warning: Function parameter or member 'new_state' not described in 'state_change'
 fs/gfs2/glock.c:1277: warning: Function parameter or member 'delay' not described in 'handle_callback'
 fs/gfs2/glock.c:1277: warning: Function parameter or member 'remote' not described in 'handle_callback'
 fs/gfs2/glock.c:1578: warning: Function parameter or member 'p' not described in 'nq_m_sync'
 fs/gfs2/glock.c:1993: warning: Excess function parameter 'wait' description in 'gfs2_gl_hash_clear'

Cc: Bob Peterson <rpeterso@redhat.com>
Cc: Andreas Gruenbacher <agruenba@redhat.com>
Cc: cluster-devel at redhat.com
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 fs/gfs2/glock.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c
index ea7fc5c641c7e..0b34f50b51331 100644
--- a/fs/gfs2/glock.c
+++ b/fs/gfs2/glock.c
@@ -356,7 +356,7 @@ static void gfs2_holder_wake(struct gfs2_holder *gh)
 	}
 }
 
-/**
+/*
  * do_error - Something unexpected has happened during a lock request
  * @gl: The glock
  * @ret: The status from the DLM
@@ -1263,7 +1263,7 @@ int gfs2_glock_async_wait(unsigned int num_gh, struct gfs2_holder *ghs)
 	return ret;
 }
 
-/**
+/*
  * handle_callback - process a demote request
  * @gl: the glock
  * @state: the state the caller wants us to change to
-- 
2.31.1

[Cluster-devel] [PATCH 02/15] fs: gfs2: glock: Fix some deficient kernel-doc headers and demote non-conformant ones

[Andreas Gruenbacher]

On Thu, May 20, 2021 at 2:00 PM Lee Jones <lee.jones@linaro.org> wrote:
> Fixes the following W=1 kernel build warning(s):
>
>  fs/gfs2/glock.c:365: warning: Function parameter or member 'gl' not described in 'do_error'
>  fs/gfs2/glock.c:365: warning: Function parameter or member 'ret' not described in 'do_error'
>  fs/gfs2/glock.c:461: warning: Function parameter or member 'new_state' not described in 'state_change'
>  fs/gfs2/glock.c:1277: warning: Function parameter or member 'delay' not described in 'handle_callback'
>  fs/gfs2/glock.c:1277: warning: Function parameter or member 'remote' not described in 'handle_callback'
>  fs/gfs2/glock.c:1578: warning: Function parameter or member 'p' not described in 'nq_m_sync'
>  fs/gfs2/glock.c:1993: warning: Excess function parameter 'wait' description in 'gfs2_gl_hash_clear'

What's that? Those warnings don't exist in mainline, and the two
warnings we have in mainline are fixed in for-next:

https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git/commit/?h=for-next&id=75069590915f2

Andreas

> Cc: Bob Peterson <rpeterso@redhat.com>
> Cc: Andreas Gruenbacher <agruenba@redhat.com>
> Cc: cluster-devel at redhat.com
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
>  fs/gfs2/glock.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c
> index ea7fc5c641c7e..0b34f50b51331 100644
> --- a/fs/gfs2/glock.c
> +++ b/fs/gfs2/glock.c
> @@ -356,7 +356,7 @@ static void gfs2_holder_wake(struct gfs2_holder *gh)
>         }
>  }
>
> -/**
> +/*
>   * do_error - Something unexpected has happened during a lock request
>   * @gl: The glock
>   * @ret: The status from the DLM
> @@ -1263,7 +1263,7 @@ int gfs2_glock_async_wait(unsigned int num_gh, struct gfs2_holder *ghs)
>         return ret;
>  }
>
> -/**
> +/*
>   * handle_callback - process a demote request
>   * @gl: the glock
>   * @state: the state the caller wants us to change to
> --
> 2.31.1
>

[Cluster-devel] [PATCH 02/15] fs: gfs2: glock: Fix some deficient kernel-doc headers and demote non-conformant ones

[Lee Jones]

On Fri, 21 May 2021, Andreas Gruenbacher wrote:

> On Thu, May 20, 2021 at 2:00 PM Lee Jones <lee.jones@linaro.org> wrote:
> > Fixes the following W=1 kernel build warning(s):
> >
> >  fs/gfs2/glock.c:365: warning: Function parameter or member 'gl' not described in 'do_error'
> >  fs/gfs2/glock.c:365: warning: Function parameter or member 'ret' not described in 'do_error'
> >  fs/gfs2/glock.c:461: warning: Function parameter or member 'new_state' not described in 'state_change'
> >  fs/gfs2/glock.c:1277: warning: Function parameter or member 'delay' not described in 'handle_callback'
> >  fs/gfs2/glock.c:1277: warning: Function parameter or member 'remote' not described in 'handle_callback'
> >  fs/gfs2/glock.c:1578: warning: Function parameter or member 'p' not described in 'nq_m_sync'
> >  fs/gfs2/glock.c:1993: warning: Excess function parameter 'wait' description in 'gfs2_gl_hash_clear'
> 
> What's that? Those warnings don't exist in mainline, and the two
> warnings we have in mainline are fixed in for-next:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git/commit/?h=for-next&id=75069590915f2

Thanks for the heads-up Andreas.

This is a rebased set that was authored last cycle.

It's great that someone has been through and fixed these already.

Tell me, is that just the case for this patch, or the whole set?

-- 
Lee Jones [???]
Senior Technical Lead - Developer Services
Linaro.org ? Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

[Cluster-devel] [PATCH 02/15] fs: gfs2: glock: Fix some deficient kernel-doc headers and demote non-conformant ones

[Lee Jones]

On Fri, 21 May 2021, Lee Jones wrote:

> On Fri, 21 May 2021, Andreas Gruenbacher wrote:
> 
> > On Thu, May 20, 2021 at 2:00 PM Lee Jones <lee.jones@linaro.org> wrote:
> > > Fixes the following W=1 kernel build warning(s):
> > >
> > >  fs/gfs2/glock.c:365: warning: Function parameter or member 'gl' not described in 'do_error'
> > >  fs/gfs2/glock.c:365: warning: Function parameter or member 'ret' not described in 'do_error'
> > >  fs/gfs2/glock.c:461: warning: Function parameter or member 'new_state' not described in 'state_change'
> > >  fs/gfs2/glock.c:1277: warning: Function parameter or member 'delay' not described in 'handle_callback'
> > >  fs/gfs2/glock.c:1277: warning: Function parameter or member 'remote' not described in 'handle_callback'
> > >  fs/gfs2/glock.c:1578: warning: Function parameter or member 'p' not described in 'nq_m_sync'
> > >  fs/gfs2/glock.c:1993: warning: Excess function parameter 'wait' description in 'gfs2_gl_hash_clear'
> > 
> > What's that? Those warnings don't exist in mainline, and the two
> > warnings we have in mainline are fixed in for-next:
> > 
> > https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git/commit/?h=for-next&id=75069590915f2
> 
> Thanks for the heads-up Andreas.
> 
> This is a rebased set that was authored last cycle.
> 
> It's great that someone has been through and fixed these already.
> 
> Tell me, is that just the case for this patch, or the whole set?

Oh, I see what's happened.

You squashed all of my patches across all of the different drivers
into a single commit for some reason.  Looks like Git didn't notice
and wilfully rebased the set, causing me to believe they hadn't been
accepted.

Dropped, thanks.

-- 
Lee Jones [???]
Senior Technical Lead - Developer Services
Linaro.org ? Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog