From: Lee Jones <lee.jones@linaro.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 02/15] fs: gfs2: glock: Fix some deficient kernel-doc headers and demote non-conformant ones
Date: Fri, 21 May 2021 07:58:22 +0100 [thread overview]
Message-ID: <20210521065822.GP2549456@dell> (raw)
In-Reply-To: <CAHc6FU429=1Hzoghqo3=hqkSSmja3+ujna=mE_-Ro=KOMTPecg@mail.gmail.com>
On Fri, 21 May 2021, Andreas Gruenbacher wrote:
> On Thu, May 20, 2021 at 2:00 PM Lee Jones <lee.jones@linaro.org> wrote:
> > Fixes the following W=1 kernel build warning(s):
> >
> > fs/gfs2/glock.c:365: warning: Function parameter or member 'gl' not described in 'do_error'
> > fs/gfs2/glock.c:365: warning: Function parameter or member 'ret' not described in 'do_error'
> > fs/gfs2/glock.c:461: warning: Function parameter or member 'new_state' not described in 'state_change'
> > fs/gfs2/glock.c:1277: warning: Function parameter or member 'delay' not described in 'handle_callback'
> > fs/gfs2/glock.c:1277: warning: Function parameter or member 'remote' not described in 'handle_callback'
> > fs/gfs2/glock.c:1578: warning: Function parameter or member 'p' not described in 'nq_m_sync'
> > fs/gfs2/glock.c:1993: warning: Excess function parameter 'wait' description in 'gfs2_gl_hash_clear'
>
> What's that? Those warnings don't exist in mainline, and the two
> warnings we have in mainline are fixed in for-next:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git/commit/?h=for-next&id=75069590915f2
Thanks for the heads-up Andreas.
This is a rebased set that was authored last cycle.
It's great that someone has been through and fixed these already.
Tell me, is that just the case for this patch, or the whole set?
--
Lee Jones [???]
Senior Technical Lead - Developer Services
Linaro.org ? Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2021-05-21 6:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-20 12:00 [Cluster-devel] [PATCH 00/15] Rid W=1 warnings from FS {GFS2, NTFS} Lee Jones
2021-05-20 12:00 ` [Cluster-devel] [PATCH 01/15] fs: gfs2: bmap: Demote half-complete kernel-doc headers fix others Lee Jones
2021-05-20 12:00 ` [Cluster-devel] [PATCH 02/15] fs: gfs2: glock: Fix some deficient kernel-doc headers and demote non-conformant ones Lee Jones
2021-05-21 3:13 ` Andreas Gruenbacher
2021-05-21 6:58 ` Lee Jones [this message]
2021-05-21 7:01 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210521065822.GP2549456@dell \
--to=lee.jones@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).