From: Andreas Gruenbacher <agruenba@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 0/2] iomap: small block problems
Date: Tue, 29 Jun 2021 11:12:39 +0200 [thread overview]
Message-ID: <20210629091239.1930040-1-agruenba@redhat.com> (raw)
In-Reply-To: <YNoJPZ4NWiqok/by@casper.infradead.org>
Below is a version of your patch on top of v5.13 which has passed some
local testing here.
Thanks,
Andreas
--
iomap: Permit pages without an iop to enter writeback
Permit pages without an iop to enter writeback and create an iop *then*. This
allows filesystems to mark pages dirty without having to worry about how the
iop block tracking is implemented.
Suggested-by: Matthew Wilcox <willy@infradead.org>
Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
---
fs/iomap/buffered-io.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c
index 03537ecb2a94..6330dabc451e 100644
--- a/fs/iomap/buffered-io.c
+++ b/fs/iomap/buffered-io.c
@@ -1336,14 +1336,13 @@ iomap_writepage_map(struct iomap_writepage_ctx *wpc,
struct writeback_control *wbc, struct inode *inode,
struct page *page, u64 end_offset)
{
- struct iomap_page *iop = to_iomap_page(page);
+ struct iomap_page *iop = iomap_page_create(inode, page);
struct iomap_ioend *ioend, *next;
unsigned len = i_blocksize(inode);
u64 file_offset; /* file offset of page */
int error = 0, count = 0, i;
LIST_HEAD(submit_list);
- WARN_ON_ONCE(i_blocks_per_page(inode, page) > 1 && !iop);
WARN_ON_ONCE(iop && atomic_read(&iop->write_bytes_pending) != 0);
/*
--
2.26.3
next prev parent reply other threads:[~2021-06-29 9:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-28 17:27 [Cluster-devel] [PATCH 0/2] iomap: small block problems Andreas Gruenbacher
2021-06-28 17:27 ` [Cluster-devel] [PATCH 1/2] iomap: Don't create iomap_page objects for inline files Andreas Gruenbacher
2021-06-30 13:35 ` Matthew Wilcox
2021-06-28 17:27 ` [Cluster-devel] [PATCH 2/2] iomap: Add helper for un-inlining an inline inode Andreas Gruenbacher
2021-06-28 17:39 ` [Cluster-devel] [PATCH 0/2] iomap: small block problems Matthew Wilcox
2021-06-28 17:47 ` Christoph Hellwig
2021-06-28 21:28 ` Andreas Gruenbacher
2021-06-28 21:59 ` Matthew Wilcox
2021-06-29 5:29 ` Christoph Hellwig
2021-06-29 5:42 ` Christoph Hellwig
2021-06-30 12:29 ` Andreas Gruenbacher
2021-07-05 15:51 ` Andreas Gruenbacher
2021-07-05 16:55 ` Christoph Hellwig
2021-06-28 17:55 ` Andreas Gruenbacher
2021-06-29 9:12 ` Andreas Gruenbacher [this message]
2021-06-30 14:08 ` Matthew Wilcox
2021-06-30 14:45 ` Andreas Gruenbacher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210629091239.1930040-1-agruenba@redhat.com \
--to=agruenba@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).