From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Date: Tue, 10 Aug 2021 09:13:12 +0200 Subject: [Cluster-devel] [PATCH 11/30] iomap: add the new iomap_iter model In-Reply-To: <20210810064509.GI3601443@magnolia> References: <20210809061244.1196573-1-hch@lst.de> <20210809061244.1196573-12-hch@lst.de> <20210809221047.GC3657114@dread.disaster.area> <20210810064509.GI3601443@magnolia> Message-ID: <20210810071312.GA16590@lst.de> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Mon, Aug 09, 2021 at 11:45:09PM -0700, Darrick J. Wong wrote: > > fs/iomap.c without having to take the tree back in time to find > > those files... > > ...or put the new code in apply.c, remove iomap_apply, and don't bother > with the renaming at all? > > I don't see much reason to break the git history. This is effectively a > new epoch in iomap, but that is plainly obvious from the function > declarations. > > I'll wander through the rest of the unreviewed patches tomorrow morning, > these are merely my off-the-cuff impressions. We could do all that, but why? There is no code even left from the apply area.