From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Date: Wed, 11 Aug 2021 07:38:56 +0200 Subject: [Cluster-devel] [PATCH 11/30] iomap: add the new iomap_iter model In-Reply-To: <20210811003118.GT3601466@magnolia> References: <20210809061244.1196573-1-hch@lst.de> <20210809061244.1196573-12-hch@lst.de> <20210811003118.GT3601466@magnolia> Message-ID: <20210811053856.GA1934@lst.de> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Tue, Aug 10, 2021 at 05:31:18PM -0700, Darrick J. Wong wrote: > > +static inline void iomap_iter_done(struct iomap_iter *iter) > > I wonder why this is a separate function, since it only has debugging > warnings and tracepoints? The reason for these two sub-helpers was to force me to structure the code so that Matthews original idea of replacing ->iomap_begin and ->iomap_end with a single next callback so that iomap_iter could be inlined into callers and the indirect calls could be elided is still possible. This would only be useful for a few specific methods (probably dax and direct I/O) where we care so much, but it seemed like a nice idea conceptually so I would not want to break it. OTOH we could just remove this function for now and do that once needed. > Modulo the question about iomap_iter_done, I guess this looks all right > to me. As far as apply.c vs. core.c, I'm not wildly passionate about > either naming choice (I would have called it iter.c) but ... fmeh. iter.c is also my preference, but in the end I don't care too much.