From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Date: Fri, 13 Aug 2021 09:29:55 +0200 Subject: [Cluster-devel] [PATCH 11/30] iomap: add the new iomap_iter model In-Reply-To: <20210812182017.GX3601466@magnolia> References: <20210809061244.1196573-1-hch@lst.de> <20210809061244.1196573-12-hch@lst.de> <20210811003118.GT3601466@magnolia> <20210811053856.GA1934@lst.de> <20210811191708.GF3601443@magnolia> <20210812064914.GA27145@lst.de> <20210812182017.GX3601466@magnolia> Message-ID: <20210813072955.GA27278@lst.de> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Thu, Aug 12, 2021 at 11:20:17AM -0700, Darrick J. Wong wrote: > The history of the gluecode that enables us to walk a bunch of extent > mappings. In the beginning it was the _apply function, but now in our > spectre-weary world, you've switched it to a direct loop to reduce the > number of indirect calls in the hot path by 30-50%. > > As you correctly point out, there's no /code/ shared by the two > implementations, but Dave and I would like to preserve the continuity > from one to the next. > > > > I'll send the updated patches as replies to this series to avoid > > > spamming the list, since I also have a patchset of bugfixes to send out > > > and don't want to overwhelm everyone. > > > > Just as a clear statement: I think this dance is obsfucation and doesn't > > help in any way. But if that's what it takes.. > > I /would/ appreciate it if you'd rvb (or at least ack) patch 31 so I can > get the 5.15 iomap changes finalized next week. Pretty please? :) I think it is a really stupid idea, so certainly no rvb or ack from me. If you feel you want to do it this way go ahead, but I do not in any way approve of it.