From: Jeff Layton <jlayton@kernel.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH v2 1/2] fs: warn about impending deprecation of mandatory locks
Date: Fri, 20 Aug 2021 09:57:06 -0400 [thread overview]
Message-ID: <20210820135707.171001-2-jlayton@kernel.org> (raw)
In-Reply-To: <20210820135707.171001-1-jlayton@kernel.org>
We've had CONFIG_MANDATORY_FILE_LOCKING since 2015 and a lot of distros
have disabled it. Warn the stragglers that still use "-o mand" that
we'll be dropping support for that mount option.
Cc: stable at vger.kernel.org
Signed-off-by: Jeff Layton <jlayton@kernel.org>
---
fs/namespace.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/fs/namespace.c b/fs/namespace.c
index ab4174a3c802..ffab0bb1e649 100644
--- a/fs/namespace.c
+++ b/fs/namespace.c
@@ -1716,8 +1716,16 @@ static inline bool may_mount(void)
}
#ifdef CONFIG_MANDATORY_FILE_LOCKING
+static bool warned_mand;
static inline bool may_mandlock(void)
{
+ if (!warned_mand) {
+ warned_mand = true;
+ pr_warn("======================================================\n");
+ pr_warn("WARNING: the mand mount option is being deprecated and\n");
+ pr_warn(" will be removed in v5.15!\n");
+ pr_warn("======================================================\n");
+ }
return capable(CAP_SYS_ADMIN);
}
#else
--
2.31.1
next prev parent reply other threads:[~2021-08-20 13:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-20 13:57 [Cluster-devel] [PATCH v2 0/2] fs: remove support for mandatory locking Jeff Layton
2021-08-20 13:57 ` Jeff Layton [this message]
2021-08-20 15:49 ` [Cluster-devel] [PATCH v2 1/2] fs: warn about impending deprecation of mandatory locks David Laight
2021-08-20 15:50 ` Jeff Layton
2021-08-20 15:52 ` David Hildenbrand
2021-08-20 16:06 ` Jeff Layton
2021-08-20 16:08 ` Steven Rostedt
2021-08-20 13:57 ` [Cluster-devel] [PATCH v2 2/2] fs: remove mandatory file locking support Jeff Layton
2021-08-20 14:09 ` [Cluster-devel] [PATCH v2 0/2] fs: remove support for mandatory locking J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210820135707.171001-2-jlayton@kernel.org \
--to=jlayton@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).