From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bob Peterson Date: Mon, 13 Sep 2021 14:30:25 -0500 Subject: [Cluster-devel] [GFS2 PATCH 1/4] gfs2: remove redundant check in gfs2_rgrp_go_lock In-Reply-To: <20210913193028.75116-1-rpeterso@redhat.com> References: <20210913193028.75116-1-rpeterso@redhat.com> Message-ID: <20210913193028.75116-2-rpeterso@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Before this patch function gfs2_rgrp_go_lock checked if GL_SKIP and ar_rgrplvb were both true. However, GL_SKIP is only set for rgrps if ar_rgrplvb is true (see gfs2_inplace_reserve). This patch simply removes the redundant check. Signed-off-by: Bob Peterson --- fs/gfs2/rgrp.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c index c3b00ba92ed2..7a13a687e4f2 100644 --- a/fs/gfs2/rgrp.c +++ b/fs/gfs2/rgrp.c @@ -1291,9 +1291,8 @@ static int update_rgrp_lvb(struct gfs2_rgrpd *rgd) int gfs2_rgrp_go_lock(struct gfs2_holder *gh) { struct gfs2_rgrpd *rgd = gh->gh_gl->gl_object; - struct gfs2_sbd *sdp = rgd->rd_sbd; - if (gh->gh_flags & GL_SKIP && sdp->sd_args.ar_rgrplvb) + if (gh->gh_flags & GL_SKIP) return 0; return gfs2_rgrp_bh_get(rgd); } -- 2.31.1