From: Alexander Aring <aahringo@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH dlm/next 0/3] fs: dlm: recovery ops and wait changes
Date: Wed, 15 Sep 2021 16:39:13 -0400 [thread overview]
Message-ID: <20210915203916.3661690-1-aahringo@redhat.com> (raw)
Hi,
this patch series changes the recovery behaviour to call
dlm_lsop_recover_prep() callback only once between dlm_ls_start() and
dlm_ls_stop(). Currently if recovery gets interrupted by another
dlm_ls_stop() it could be we calling this callback multiple times and
the dlm_lsop_recover_done() was not called yet. Users might depend on the
behaviour that the dlm_lsop_recover_prep() is only called once followed
by a final dlm_lsop_recover_done() call.
Another change is that dlm_new_lockspace() will wait until the recovery is
done. The current behaviour is that the dlm_new_lockspace() will wait until
lockspace member configuration seems to be valid. After the members
configuration the recovery can still get interrupted by another
dlm_ls_stop() call and dlm_new_lockspace() moves on at that point when
recovery is still not done yet. The most kernel users have already a wait
for the dlm_lsop_recover_done() after calling dlm_new_lockspace() which
is not necessary now. However the old behaviour should still work.
I tested this patch series with an experimental python bindings to libdlm.
I will send soon patches which will add those bindings and test to the
dlm user space software repository.
- Alex
Alexander Aring (3):
fs: dlm: add notes for recovery and membership handling
fs: dlm: call dlm_lsop_recover_prep once
fs: dlm: let new_lockspace() wait until recovery
fs/dlm/dlm_internal.h | 4 ++--
fs/dlm/lockspace.c | 9 +++++----
fs/dlm/member.c | 30 +++++++++++++++---------------
fs/dlm/recoverd.c | 17 +++++++++++++++++
4 files changed, 39 insertions(+), 21 deletions(-)
--
2.27.0
next reply other threads:[~2021-09-15 20:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 20:39 Alexander Aring [this message]
2021-09-15 20:39 ` [Cluster-devel] [PATCH dlm/next 1/3] fs: dlm: add notes for recovery and membership handling Alexander Aring
2021-09-15 20:39 ` [Cluster-devel] [PATCH dlm/next 2/3] fs: dlm: call dlm_lsop_recover_prep once Alexander Aring
2021-09-15 20:39 ` [Cluster-devel] [PATCH dlm/next 3/3] fs: dlm: let new_lockspace() wait until recovery Alexander Aring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210915203916.3661690-1-aahringo@redhat.com \
--to=aahringo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).