From: Alexander Aring <aahringo@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH dlm/next 2/3] fs: dlm: call dlm_lsop_recover_prep once
Date: Wed, 15 Sep 2021 16:39:15 -0400 [thread overview]
Message-ID: <20210915203916.3661690-3-aahringo@redhat.com> (raw)
In-Reply-To: <20210915203916.3661690-1-aahringo@redhat.com>
This patch changes the behaviour of "dlm_lsop_recover_prep" callback. It
will be called once when locking was stopped if it was previously
running not if dlm_ls_stop() is called multiple times when locking was
already stopped. Now it will be called only if a dlm_ls_start() was before.
Signed-off-by: Alexander Aring <aahringo@redhat.com>
---
fs/dlm/member.c | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/fs/dlm/member.c b/fs/dlm/member.c
index 5f5b07bdbcc3..446e1635229d 100644
--- a/fs/dlm/member.c
+++ b/fs/dlm/member.c
@@ -685,7 +685,16 @@ int dlm_ls_stop(struct dlm_ls *ls)
if (!ls->ls_recover_begin)
ls->ls_recover_begin = jiffies;
- dlm_lsop_recover_prep(ls);
+ /* call recover_prep ops only once and not multiple times
+ * for each possible dlm_ls_stop() when recovery is already
+ * stopped.
+ *
+ * If we successful was able to clear LSFL_RUNNING bit and
+ * it was set we know it is the first dlm_ls_stop() call.
+ */
+ if (new)
+ dlm_lsop_recover_prep(ls);
+
return 0;
}
--
2.27.0
next prev parent reply other threads:[~2021-09-15 20:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 20:39 [Cluster-devel] [PATCH dlm/next 0/3] fs: dlm: recovery ops and wait changes Alexander Aring
2021-09-15 20:39 ` [Cluster-devel] [PATCH dlm/next 1/3] fs: dlm: add notes for recovery and membership handling Alexander Aring
2021-09-15 20:39 ` Alexander Aring [this message]
2021-09-15 20:39 ` [Cluster-devel] [PATCH dlm/next 3/3] fs: dlm: let new_lockspace() wait until recovery Alexander Aring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210915203916.3661690-3-aahringo@redhat.com \
--to=aahringo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).