From: Alexander Aring <aahringo@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH dlm-tool 3/6] stonith_helper: Fix gcc build warnings
Date: Thu, 2 Dec 2021 15:20:36 -0500 [thread overview]
Message-ID: <20211202202039.1386193-4-aahringo@redhat.com> (raw)
In-Reply-To: <20211202202039.1386193-1-aahringo@redhat.com>
Took it from the debian patches. The return value of getopt() is int not
char. This patch switches the return value which is stored in variable
c to int.
Reported-by: Valentin Vidic <vvidic@debian.org>
---
fence/stonith_helper.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/fence/stonith_helper.c b/fence/stonith_helper.c
index b1db352a..92fe0e5d 100644
--- a/fence/stonith_helper.c
+++ b/fence/stonith_helper.c
@@ -25,8 +25,7 @@ static int get_options(int argc, char *argv[])
char arg[MAX_ARG_LEN];
char key[MAX_ARG_LEN];
char val[MAX_ARG_LEN];
- char c;
- int rv;
+ int rv, c;
if (argc > 1) {
while ((c = getopt(argc, argv, "n:t:")) != -1) {
--
2.27.0
next prev parent reply other threads:[~2021-12-02 20:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-02 20:20 [Cluster-devel] [PATCH dlm-tool 0/6] dlm: debian patches and python Alexander Aring
2021-12-02 20:20 ` [Cluster-devel] [PATCH dlm-tool 1/6] init: Enable systemctl help dlm to show relevant man pages Alexander Aring
2021-12-02 20:20 ` [Cluster-devel] [PATCH dlm-tool 2/6] dlm_controld: man: Fix typo: specfic => specific Alexander Aring
2021-12-02 20:20 ` Alexander Aring [this message]
2021-12-02 20:20 ` [Cluster-devel] [PATCH dlm-tool 4/6] stonith_helper: Don't link dlm_stonith against libxml2 Alexander Aring
2021-12-02 20:20 ` [Cluster-devel] [PATCH dlm-tool 5/6] python: add bindings and test example Alexander Aring
2021-12-02 20:20 ` [Cluster-devel] [PATCH dlm-tool 6/6] python: add ebpf histogram example Alexander Aring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211202202039.1386193-4-aahringo@redhat.com \
--to=aahringo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).