cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Bob Peterson <rpeterso@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [Patch 19/44] fsck.gfs2: Move function check_num_ptrs from metawalk.c to pass1.c
Date: Fri, 12 Aug 2011 10:03:19 -0400 (EDT)	[thread overview]
Message-ID: <2021607600.552497.1313157799975.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com> (raw)
In-Reply-To: <1313142073.2704.37.camel@menhir>

----- Original Message -----
| Hi,
| 
| This looks a bit confusing. The number of pointers in a leaf block is,
| in general, not a power of two. I assume that this refers to the dir
| hash table and maybe needs renaming accordingly?
| 
| Steve.

Hi,

You're right that the number of pointers _in_ a leaf block is not
a power of two.  However, the code here is trying to reconcile
the number of pointers _to_ a leaf block (from the hash table)
to the leaf block's di_depth.  The number of pointers in the hash
table pointing to any given leaf block is, in fact, a power of 2
and that must be checked and fixed if necessary.

I'll see if I can adjust the patch to add some comments or
somehow be less confusing.

Regards,

Bob Peterson
Red Hat File Systems



      reply	other threads:[~2011-08-12 14:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-11 21:06 [Cluster-devel] [Patch 19/44] fsck.gfs2: Move function check_num_ptrs from metawalk.c to pass1.c Bob Peterson
2011-08-12  9:41 ` Steven Whitehouse
2011-08-12 14:03   ` Bob Peterson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2021607600.552497.1313157799975.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com \
    --to=rpeterso@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).