From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bob Peterson Date: Fri, 12 Aug 2011 10:03:19 -0400 (EDT) Subject: [Cluster-devel] [Patch 19/44] fsck.gfs2: Move function check_num_ptrs from metawalk.c to pass1.c In-Reply-To: <1313142073.2704.37.camel@menhir> Message-ID: <2021607600.552497.1313157799975.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit ----- Original Message ----- | Hi, | | This looks a bit confusing. The number of pointers in a leaf block is, | in general, not a power of two. I assume that this refers to the dir | hash table and maybe needs renaming accordingly? | | Steve. Hi, You're right that the number of pointers _in_ a leaf block is not a power of two. However, the code here is trying to reconcile the number of pointers _to_ a leaf block (from the hash table) to the leaf block's di_depth. The number of pointers in the hash table pointing to any given leaf block is, in fact, a power of 2 and that must be checked and fixed if necessary. I'll see if I can adjust the patch to add some comments or somehow be less confusing. Regards, Bob Peterson Red Hat File Systems