From: Alexander Aring <aahringo@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCHv2 dlm/next 5/6] fs: dlm: remove unnecessary INIT_LIST_HEAD()
Date: Thu, 17 Feb 2022 14:39:16 -0500 [thread overview]
Message-ID: <20220217193917.3292717-6-aahringo@redhat.com> (raw)
In-Reply-To: <20220217193917.3292717-1-aahringo@redhat.com>
There is no need to call INIT_LIST_HEAD() when it's set directly
afterwards by list_add_tail().
Reported-by: Andreas Gruenbacher <agruenba@redhat.com>
Signed-off-by: Alexander Aring <aahringo@redhat.com>
---
fs/dlm/plock.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/dlm/plock.c b/fs/dlm/plock.c
index ce1af7986e16..ff439d780cb1 100644
--- a/fs/dlm/plock.c
+++ b/fs/dlm/plock.c
@@ -67,7 +67,6 @@ static void dlm_release_plock_op(struct plock_op *op)
static void send_op(struct plock_op *op)
{
set_version(&op->info);
- INIT_LIST_HEAD(&op->list);
spin_lock(&ops_lock);
list_add_tail(&op->list, &send_list);
spin_unlock(&ops_lock);
--
2.31.1
next prev parent reply other threads:[~2022-02-17 19:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-17 19:39 [Cluster-devel] [PATCHv2 dlm/next 0/6] fs: dlm: cleanup plock code Alexander Aring
2022-02-17 19:39 ` [Cluster-devel] [PATCHv2 dlm/next 1/6] fs: dlm: replace sanity checks with WARN_ON Alexander Aring
2022-02-17 19:39 ` [Cluster-devel] [PATCHv2 dlm/next 2/6] fs: dlm: cleanup plock_op vs plock_xop Alexander Aring
2022-02-17 19:39 ` [Cluster-devel] [PATCHv2 dlm/next 3/6] fs: dlm: rearrange async condition return Alexander Aring
2022-02-17 19:39 ` [Cluster-devel] [PATCHv2 dlm/next 4/6] fs: dlm: improve plock logging if interrupted Alexander Aring
2022-02-17 19:39 ` Alexander Aring [this message]
2022-02-17 19:39 ` [Cluster-devel] [PATCHv2 dlm/next 6/6] fs: dlm: move global to static inits Alexander Aring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220217193917.3292717-6-aahringo@redhat.com \
--to=aahringo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).