From: Alexander Aring <aahringo@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCHv2 dlm/next 6/6] fs: dlm: move global to static inits
Date: Thu, 17 Feb 2022 14:39:17 -0500 [thread overview]
Message-ID: <20220217193917.3292717-7-aahringo@redhat.com> (raw)
In-Reply-To: <20220217193917.3292717-1-aahringo@redhat.com>
Instead of init global module at module loading time we can move the
initialization of those global variables at memory initialization of the
module loader.
Signed-off-by: Alexander Aring <aahringo@redhat.com>
---
fs/dlm/plock.c | 16 +++++-----------
1 file changed, 5 insertions(+), 11 deletions(-)
diff --git a/fs/dlm/plock.c b/fs/dlm/plock.c
index ff439d780cb1..16241fe6ac3c 100644
--- a/fs/dlm/plock.c
+++ b/fs/dlm/plock.c
@@ -13,11 +13,11 @@
#include "dlm_internal.h"
#include "lockspace.h"
-static spinlock_t ops_lock;
-static struct list_head send_list;
-static struct list_head recv_list;
-static wait_queue_head_t send_wq;
-static wait_queue_head_t recv_wq;
+static DEFINE_SPINLOCK(ops_lock);
+static LIST_HEAD(send_list);
+static LIST_HEAD(recv_list);
+static DECLARE_WAIT_QUEUE_HEAD(send_wq);
+static DECLARE_WAIT_QUEUE_HEAD(recv_wq);
struct plock_async_data {
void *fl;
@@ -480,12 +480,6 @@ int dlm_plock_init(void)
{
int rv;
- spin_lock_init(&ops_lock);
- INIT_LIST_HEAD(&send_list);
- INIT_LIST_HEAD(&recv_list);
- init_waitqueue_head(&send_wq);
- init_waitqueue_head(&recv_wq);
-
rv = misc_register(&plock_dev_misc);
if (rv)
log_print("dlm_plock_init: misc_register failed %d", rv);
--
2.31.1
prev parent reply other threads:[~2022-02-17 19:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-17 19:39 [Cluster-devel] [PATCHv2 dlm/next 0/6] fs: dlm: cleanup plock code Alexander Aring
2022-02-17 19:39 ` [Cluster-devel] [PATCHv2 dlm/next 1/6] fs: dlm: replace sanity checks with WARN_ON Alexander Aring
2022-02-17 19:39 ` [Cluster-devel] [PATCHv2 dlm/next 2/6] fs: dlm: cleanup plock_op vs plock_xop Alexander Aring
2022-02-17 19:39 ` [Cluster-devel] [PATCHv2 dlm/next 3/6] fs: dlm: rearrange async condition return Alexander Aring
2022-02-17 19:39 ` [Cluster-devel] [PATCHv2 dlm/next 4/6] fs: dlm: improve plock logging if interrupted Alexander Aring
2022-02-17 19:39 ` [Cluster-devel] [PATCHv2 dlm/next 5/6] fs: dlm: remove unnecessary INIT_LIST_HEAD() Alexander Aring
2022-02-17 19:39 ` Alexander Aring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220217193917.3292717-7-aahringo@redhat.com \
--to=aahringo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).