From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Aring Date: Thu, 17 Feb 2022 14:39:17 -0500 Subject: [Cluster-devel] [PATCHv2 dlm/next 6/6] fs: dlm: move global to static inits In-Reply-To: <20220217193917.3292717-1-aahringo@redhat.com> References: <20220217193917.3292717-1-aahringo@redhat.com> Message-ID: <20220217193917.3292717-7-aahringo@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Instead of init global module at module loading time we can move the initialization of those global variables at memory initialization of the module loader. Signed-off-by: Alexander Aring --- fs/dlm/plock.c | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/fs/dlm/plock.c b/fs/dlm/plock.c index ff439d780cb1..16241fe6ac3c 100644 --- a/fs/dlm/plock.c +++ b/fs/dlm/plock.c @@ -13,11 +13,11 @@ #include "dlm_internal.h" #include "lockspace.h" -static spinlock_t ops_lock; -static struct list_head send_list; -static struct list_head recv_list; -static wait_queue_head_t send_wq; -static wait_queue_head_t recv_wq; +static DEFINE_SPINLOCK(ops_lock); +static LIST_HEAD(send_list); +static LIST_HEAD(recv_list); +static DECLARE_WAIT_QUEUE_HEAD(send_wq); +static DECLARE_WAIT_QUEUE_HEAD(recv_wq); struct plock_async_data { void *fl; @@ -480,12 +480,6 @@ int dlm_plock_init(void) { int rv; - spin_lock_init(&ops_lock); - INIT_LIST_HEAD(&send_list); - INIT_LIST_HEAD(&recv_list); - init_waitqueue_head(&send_wq); - init_waitqueue_head(&recv_wq); - rv = misc_register(&plock_dev_misc); if (rv) log_print("dlm_plock_init: misc_register failed %d", rv); -- 2.31.1