cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Alexander Aring <aahringo@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH/RFC dlm/next 2/9] fs: dlm: use __le types for options header
Date: Wed, 23 Feb 2022 12:08:22 -0500	[thread overview]
Message-ID: <20220223170829.830864-3-aahringo@redhat.com> (raw)
In-Reply-To: <20220223170829.830864-1-aahringo@redhat.com>

This patch changes to use __le types directly in the dlm option headers
structures which are casted at the right dlm message buffer positions.

Currently only midcomms.c using those headers which already was calling
endian conversions on-the-fly without using in/out functionality like
other endianness handling in dlm. Using __le types now will hopefully get
useful warnings in future if we do comparison against host byte order
values.

Signed-off-by: Alexander Aring <aahringo@redhat.com>
---
 fs/dlm/dlm_internal.h | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/fs/dlm/dlm_internal.h b/fs/dlm/dlm_internal.h
index 74a9590a4dd5..2bd1b249f2ee 100644
--- a/fs/dlm/dlm_internal.h
+++ b/fs/dlm/dlm_internal.h
@@ -460,9 +460,9 @@ struct dlm_rcom {
 };
 
 struct dlm_opt_header {
-	uint16_t	t_type;
-	uint16_t	t_length;
-	uint32_t	t_pad;
+	__le16		t_type;
+	__le16		t_length;
+	__le32		t_pad;
 	/* need to be 8 byte aligned */
 	char		t_value[];
 };
@@ -472,8 +472,8 @@ struct dlm_opts {
 	struct dlm_header	o_header;
 	uint8_t			o_nextcmd;
 	uint8_t			o_pad;
-	uint16_t		o_optlen;
-	uint32_t		o_pad2;
+	__le16			o_optlen;
+	__le32			o_pad2;
 	char			o_opts[];
 };
 
-- 
2.31.1



  parent reply	other threads:[~2022-02-23 17:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-23 17:08 [Cluster-devel] [PATCH/RFC dlm/next 0/9] fs: dlm: change lock and endianness handling Alexander Aring
2022-02-23 17:08 ` [Cluster-devel] [PATCH/RFC dlm/next 1/9] fs: dlm: add __CHECKER__ for false positives Alexander Aring
2022-02-23 17:08 ` Alexander Aring [this message]
2022-02-23 17:08 ` [Cluster-devel] [PATCH/RFC dlm/next 3/9] fs: dlm: use __le types for dlm header Alexander Aring
2022-02-23 17:08 ` [Cluster-devel] [PATCH/RFC dlm/next 4/9] fs: dlm: use __le types for rcom messages Alexander Aring
2022-02-23 17:08 ` [Cluster-devel] [PATCH/RFC dlm/next 5/9] fs: dlm: use __le types for dlm messages Alexander Aring
2022-02-23 17:08 ` [Cluster-devel] [PATCH/RFC dlm/next 6/9] fs: dlm: move conversion to compile time Alexander Aring
2022-02-23 17:08 ` [Cluster-devel] [PATCH/RFC dlm/next 7/9] fs: dlm: remove __user conversion warnings Alexander Aring
2022-02-23 17:08 ` [Cluster-devel] [PATCH/RFC dlm/next 8/9] fs: dlm: remove found label in dlm_master_lookup Alexander Aring
2022-02-23 17:08 ` [Cluster-devel] [PATCH/RFC dlm/next 9/9] fs: dlm: cleanup lock handling " Alexander Aring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220223170829.830864-3-aahringo@redhat.com \
    --to=aahringo@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).