From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Aring Date: Mon, 2 May 2022 11:14:08 -0400 Subject: [Cluster-devel] [PATCH dlm/next 1/3] fs: dlm: remove unnecessary error assign Message-ID: <20220502151410.4049410-1-aahringo@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit This patch removes unnecessary error assigns to 0 at places we know that error is zero because it was checked on non-zero before. Signed-off-by: Alexander Aring --- fs/dlm/lock.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c index d19cfa03c9bb..97ca728dc194 100644 --- a/fs/dlm/lock.c +++ b/fs/dlm/lock.c @@ -602,7 +602,6 @@ static int find_rsb_dir(struct dlm_ls *ls, char *name, int len, */ kref_get(&r->res_ref); - error = 0; goto out_unlock; @@ -1091,7 +1090,6 @@ int dlm_master_lookup(struct dlm_ls *ls, int from_nodeid, char *name, int len, if (result) *result = DLM_LU_ADD; *r_nodeid = from_nodeid; - error = 0; out_unlock: spin_unlock(&ls->ls_rsbtbl[b].lock); return error; @@ -5747,7 +5745,6 @@ int dlm_recover_master_copy(struct dlm_ls *ls, struct dlm_rcom *rc) attach_lkb(r, lkb); add_lkb(r, lkb, rl->rl_status); - error = 0; ls->ls_recover_locks_in++; if (!list_empty(&r->res_waitqueue) || !list_empty(&r->res_convertqueue)) -- 2.31.1