cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Andreas Gruenbacher <agruenba@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [GIT PULL] gfs2 fixes
Date: Fri, 13 May 2022 23:07:10 +0200	[thread overview]
Message-ID: <20220513210710.4124506-1-agruenba@redhat.com> (raw)

Hi Linus,

we've finally identified commit dc732906c245 ("gfs2: Introduce flag for glock
holder auto-demotion") to be the other cause of the filesystem corruption we've
been seeing.  This feature isn't strictly necessary anymore, so we've decided
to stop using it for now.  With this and the gfs_iomap_end rounding fix you've
already seen ("gfs2: Fix filesystem block deallocation for short writes" in
this pull request), we're corruption free again now.

Would you like to still pull these fixes for v5.18, or should we send them in
the next merge window?

Thanks again for all the help you've provided.

Andreas

The following changes since commit 4a2316a1eda4ef3ced18c7f08f7cb3726bcae44b:

  Merge tag 'gfs2-v5.18-rc4-fix2' of git://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2 (2022-04-28 09:50:29 -0700)

are available in the Git repository at:

  https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git tags/gfs2-v5.18-rc4-fix3

for you to fetch changes up to e1fa9ea85ce89207d2ac0316da35a4a7736801f9:

  gfs2: Stop using glock holder auto-demotion for now (2022-05-13 22:32:52 +0200)

----------------------------------------------------------------
gfs2 fixes

- Fix filesystem block deallocation for short writes.
- Stop using glock holder auto-demotion for now.
- Get rid of buffered writes inefficiencies due to page
  faults being disabled.
- Minor other cleanups.

----------------------------------------------------------------
Andreas Gruenbacher (7):
      gfs2: Fix filesystem block deallocation for short writes
      gfs2: Variable rename
      gfs2: Clean up use of fault_in_iov_iter_{read,write}able
      gfs2: Pull return value test out of should_fault_in_pages
      gfs2: Align read and write chunks to the page cache
      gfs2: buffered write prefaulting
      gfs2: Stop using glock holder auto-demotion for now

 fs/gfs2/bmap.c |  11 +++--
 fs/gfs2/file.c | 139 ++++++++++++++++++++++++++-------------------------------
 2 files changed, 68 insertions(+), 82 deletions(-)

             reply	other threads:[~2022-05-13 21:07 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-13 21:07 Andreas Gruenbacher [this message]
2022-05-13 21:35 ` [Cluster-devel] [GIT PULL] gfs2 fixes Linus Torvalds
2022-05-13 21:38 ` pr-tracker-bot
  -- strict thread matches above, loose matches on Subject: below --
2023-09-05 16:12 Andreas Gruenbacher
2023-09-05 20:14 ` pr-tracker-bot
2023-08-08 12:53 Andreas Gruenbacher
2023-08-08 17:00 ` pr-tracker-bot
2023-07-04 12:51 Andreas Gruenbacher
2023-07-04 18:59 ` pr-tracker-bot
2023-02-22 12:01 Andreas Gruenbacher
2023-02-22 22:27 ` pr-tracker-bot
2022-12-16 14:33 Andreas Gruenbacher
2022-12-17 14:28 ` pr-tracker-bot
2022-10-09 10:45 Andreas Gruenbacher
2022-10-11  3:43 ` pr-tracker-bot
2022-08-05 20:12 Andreas Gruenbacher
2022-08-06 22:08 ` pr-tracker-bot
2022-05-24 19:41 Andreas Gruenbacher
2022-05-25  2:16 ` pr-tracker-bot
2022-02-11 17:05 Andreas Gruenbacher
2022-02-11 19:47 ` Linus Torvalds
2022-02-11 21:40   ` Andreas Gruenbacher
2022-02-11 20:05 ` pr-tracker-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220513210710.4124506-1-agruenba@redhat.com \
    --to=agruenba@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).