From: Alexander Aring <aahringo@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH dlm/next 4/6] fs: dlm: change log output to debug again
Date: Thu, 26 May 2022 16:15:30 -0400 [thread overview]
Message-ID: <20220526201532.463135-4-aahringo@redhat.com> (raw)
In-Reply-To: <20220526201532.463135-1-aahringo@redhat.com>
This patch revers the commit bcfad4265ced ("dlm: improve plock logging
if interrupted") by moving it to debug level and noticing the user an op
was removed from the kernel user space mechanism handling.
A new approach will be made that an op should never be removed when
waiting from an answer from the user space side.
Signed-off-by: Alexander Aring <aahringo@redhat.com>
---
fs/dlm/plock.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/dlm/plock.c b/fs/dlm/plock.c
index a58598c3edc5..868940c48e3a 100644
--- a/fs/dlm/plock.c
+++ b/fs/dlm/plock.c
@@ -163,7 +163,7 @@ int dlm_posix_lock(dlm_lockspace_t *lockspace, u64 number, struct file *file,
spin_lock(&ops_lock);
list_del(&op->list);
spin_unlock(&ops_lock);
- log_print("%s: wait interrupted %x %llx pid %d, op removed",
+ log_debug(ls, "%s: wait interrupted %x %llx pid %d",
__func__, ls->ls_global_id,
(unsigned long long)number, op->info.pid);
dlm_release_plock_op(op);
--
2.31.1
next prev parent reply other threads:[~2022-05-26 20:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-26 20:15 [Cluster-devel] [PATCH dlm/next 1/6] fs: dlm: plock use list_first_entry Alexander Aring
2022-05-26 20:15 ` [Cluster-devel] [PATCH dlm/next 2/6] fs: dlm: remove may interrupted message Alexander Aring
2022-05-26 20:15 ` [Cluster-devel] [PATCH dlm/next 3/6] fs: dlm: add pid to debug log Alexander Aring
2022-05-26 20:15 ` Alexander Aring [this message]
2022-05-26 20:15 ` [Cluster-devel] [PATCH dlm/next 5/6] fs: dlm: use dlm_plock_info for do_unlock_close Alexander Aring
2022-05-26 20:15 ` [Cluster-devel] [PATCH dlm/next 6/6] fs: dlm: change posix lock sigint handling Alexander Aring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220526201532.463135-4-aahringo@redhat.com \
--to=aahringo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).