From: Matthew Wilcox (Oracle) <willy@infradead.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH v2 13/19] ubifs: Convert to filemap_migrate_folio()
Date: Wed, 8 Jun 2022 16:02:43 +0100 [thread overview]
Message-ID: <20220608150249.3033815-14-willy@infradead.org> (raw)
In-Reply-To: <20220608150249.3033815-1-willy@infradead.org>
filemap_migrate_folio() is a little more general than ubifs really needs,
but it's better to share the code.
Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
---
fs/ubifs/file.c | 29 ++---------------------------
1 file changed, 2 insertions(+), 27 deletions(-)
diff --git a/fs/ubifs/file.c b/fs/ubifs/file.c
index 04ced154960f..f2353dd676ef 100644
--- a/fs/ubifs/file.c
+++ b/fs/ubifs/file.c
@@ -1461,29 +1461,6 @@ static bool ubifs_dirty_folio(struct address_space *mapping,
return ret;
}
-#ifdef CONFIG_MIGRATION
-static int ubifs_migrate_page(struct address_space *mapping,
- struct page *newpage, struct page *page, enum migrate_mode mode)
-{
- int rc;
-
- rc = migrate_page_move_mapping(mapping, newpage, page, 0);
- if (rc != MIGRATEPAGE_SUCCESS)
- return rc;
-
- if (PagePrivate(page)) {
- detach_page_private(page);
- attach_page_private(newpage, (void *)1);
- }
-
- if (mode != MIGRATE_SYNC_NO_COPY)
- migrate_page_copy(newpage, page);
- else
- migrate_page_states(newpage, page);
- return MIGRATEPAGE_SUCCESS;
-}
-#endif
-
static bool ubifs_release_folio(struct folio *folio, gfp_t unused_gfp_flags)
{
struct inode *inode = folio->mapping->host;
@@ -1649,10 +1626,8 @@ const struct address_space_operations ubifs_file_address_operations = {
.write_end = ubifs_write_end,
.invalidate_folio = ubifs_invalidate_folio,
.dirty_folio = ubifs_dirty_folio,
-#ifdef CONFIG_MIGRATION
- .migratepage = ubifs_migrate_page,
-#endif
- .release_folio = ubifs_release_folio,
+ .migrate_folio = filemap_migrate_folio,
+ .release_folio = ubifs_release_folio,
};
const struct inode_operations ubifs_file_inode_operations = {
--
2.35.1
next prev parent reply other threads:[~2022-06-08 15:02 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-08 15:02 [Cluster-devel] [PATCH v2 00/19] Convert aops->migratepage to aops->migrate_folio Matthew Wilcox
2022-06-08 15:02 ` [Cluster-devel] [PATCH v2 01/19] secretmem: Remove isolate_page Matthew Wilcox
2022-06-09 12:46 ` David Hildenbrand
2022-06-08 15:02 ` [Cluster-devel] [PATCH v2 02/19] mm: Convert all PageMovable users to movable_operations Matthew Wilcox
2022-06-09 10:23 ` David Hildenbrand
2022-06-08 15:02 ` [Cluster-devel] [PATCH v2 03/19] fs: Add aops->migrate_folio Matthew Wilcox
2022-06-09 12:50 ` David Hildenbrand
2022-06-09 14:35 ` Matthew Wilcox
2022-06-10 10:17 ` David Hildenbrand
2022-06-08 15:02 ` [Cluster-devel] [PATCH v2 04/19] mm/migrate: Convert fallback_migrate_page() to fallback_migrate_folio() Matthew Wilcox
2022-06-08 15:02 ` [Cluster-devel] [PATCH v2 05/19] mm/migrate: Convert writeout() to take a folio Matthew Wilcox
2022-06-08 15:02 ` [Cluster-devel] [PATCH v2 06/19] mm/migrate: Convert buffer_migrate_page() to buffer_migrate_folio() Matthew Wilcox
2022-06-08 15:02 ` [Cluster-devel] [PATCH v2 07/19] mm/migrate: Convert expected_page_refs() to folio_expected_refs() Matthew Wilcox
2022-07-08 2:50 ` Hugh Dickins
2022-07-08 3:29 ` Matthew Wilcox
2022-06-08 15:02 ` [Cluster-devel] [PATCH v2 08/19] btrfs: Convert btree_migratepage to migrate_folio Matthew Wilcox
2022-06-09 16:25 ` David Sterba
2022-06-08 15:02 ` [Cluster-devel] [PATCH v2 09/19] nfs: Convert " Matthew Wilcox
2022-06-08 15:02 ` [Cluster-devel] [PATCH v2 10/19] mm/migrate: Convert migrate_page() to migrate_folio() Matthew Wilcox
2022-06-09 16:26 ` David Sterba
2022-06-08 15:02 ` [Cluster-devel] [PATCH v2 11/19] mm/migrate: Add filemap_migrate_folio() Matthew Wilcox
2022-06-08 15:22 ` Darrick J. Wong
2022-06-08 15:02 ` [Cluster-devel] [PATCH v2 12/19] btrfs: Convert btrfs_migratepage to migrate_folio Matthew Wilcox
2022-06-09 16:33 ` David Sterba
2022-06-09 17:40 ` Matthew Wilcox
2022-06-09 23:05 ` David Sterba
2022-06-08 15:02 ` Matthew Wilcox [this message]
2022-06-08 15:02 ` [Cluster-devel] [PATCH v2 14/19] f2fs: Convert to filemap_migrate_folio() Matthew Wilcox
2022-06-15 8:11 ` [Cluster-devel] [f2fs-dev] " Chao Yu
2022-06-08 15:02 ` [Cluster-devel] [PATCH v2 15/19] aio: Convert to migrate_folio Matthew Wilcox
2022-06-08 15:02 ` [Cluster-devel] [PATCH v2 16/19] hugetlb: " Matthew Wilcox
2022-06-09 3:53 ` Muchun Song
2022-06-09 20:51 ` Mike Kravetz
2022-06-08 15:02 ` [Cluster-devel] [PATCH v2 17/19] secretmem: " Matthew Wilcox
2022-06-08 15:02 ` [Cluster-devel] [PATCH v2 18/19] fs: Remove aops->migratepage() Matthew Wilcox
2022-06-08 15:02 ` [Cluster-devel] [PATCH v2 19/19] mm/folio-compat: Remove migration compatibility functions Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220608150249.3033815-14-willy@infradead.org \
--to=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).