cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Alexander Aring <aahringo@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH dlm/next 1/5] fs: dlm: add comment about lkb IFL flags
Date: Fri, 17 Jun 2022 16:00:32 -0400	[thread overview]
Message-ID: <20220617200036.251778-2-aahringo@redhat.com> (raw)
In-Reply-To: <20220617200036.251778-1-aahringo@redhat.com>

This patch adds comments about the difference between the lower 2 bytes
of lkb flags and the 2 upper bytes of the lkb IFL flags. In short the
upper 2 bytes will be handled as internal flags whereas the lower 2
bytes are part of the DLM protocol and are used to exchange messages.

Signed-off-by: Alexander Aring <aahringo@redhat.com>
---
 fs/dlm/dlm_internal.h | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/fs/dlm/dlm_internal.h b/fs/dlm/dlm_internal.h
index c03388a3875c..151f98fc3f22 100644
--- a/fs/dlm/dlm_internal.h
+++ b/fs/dlm/dlm_internal.h
@@ -207,6 +207,13 @@ struct dlm_args {
 #define DLM_IFL_TIMEOUT_CANCEL	0x00800000
 #define DLM_IFL_DEADLOCK_CANCEL	0x01000000
 #define DLM_IFL_STUB_MS		0x02000000 /* magic number for m_flags */
+/* least significant 2 bytes are message changed, they are full transmitted
+ * but at receive side only the 2 bytes LSB will be set.
+ *
+ * Even wireshark dlm dissector does only evaluate the lower bytes and note
+ * that they may not be used on transceiver side, we assume the higher bytes
+ * are for internal use or reserved so long they are parsed on receiver side.
+ */
 #define DLM_IFL_USER		0x00000001
 #define DLM_IFL_ORPHAN		0x00000002
 
-- 
2.31.1


  reply	other threads:[~2022-06-17 20:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-17 20:00 [Cluster-devel] [PATCH dlm/next 0/5] fs: dlm: prepare for deprecate DLM API Alexander Aring
2022-06-17 20:00 ` Alexander Aring [this message]
2022-06-17 22:28   ` [Cluster-devel] [PATCH dlm/next 1/5] fs: dlm: add comment about lkb IFL flags Alexander Aring
2022-06-17 20:00 ` [Cluster-devel] [PATCH dlm/next 2/5] fs: dlm: remove warn waiter handling Alexander Aring
2022-06-17 22:29   ` Alexander Aring
2022-06-17 20:00 ` [Cluster-devel] [PATCH dlm/next 3/5] fs: dlm: remove timeout from dlm_user_adopt_orphan Alexander Aring
2022-06-17 20:00 ` [Cluster-devel] [PATCH dlm/next 4/5] fs: dlm: add API deprecation warning Alexander Aring
2022-06-17 20:00 ` [Cluster-devel] [PATCH dlm/next 5/5] fs: dlm: don't use deprecated API by default Alexander Aring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220617200036.251778-2-aahringo@redhat.com \
    --to=aahringo@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).