cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Andreas Gruenbacher <agruenba@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 0/9] gfs2: glock instantiation and holder auto-demotion fixes
Date: Wed, 29 Jun 2022 18:37:02 +0200	[thread overview]
Message-ID: <20220629163711.732931-1-agruenba@redhat.com> (raw)

So far, glocks were instantiated inside of do_promote() as part of the
glock state engine logic.  This code can be moved outside the state
engine, which simplifies things significantly.  We no longer need to
release and re-acquire the glock spin lock in do_promote(), so the glock
holder we're trying to instantiate can no longer go away under us by
accident.  (Function do_promote() isn't always run in process context.)

To facilitate that, first fix and clean up gfs2_glock_async_wait() to
take advantage of the fact that canceling glock operations now works
properly.

With the above changes in place, split off a new go_held() glock
operation for actions to be performed whenever a new holder for a glock
is granted:  some of the actions carried out by inode_go_instantiate()
are meant to be carried out repeatedly, so move those over to the new
inode_go_held() handler.

Finally, Bob has found the remaining bug in the glock holder
auto-demotion feature we've disabled for 5.18; fix that and re-enable
the feature.

Thanks,
Andreas

Andreas Gruenbacher (8):
  gfs2: Fix up gfs2_glock_async_wait
  gfs2: Instantiate glocks ouside of glock state engine
  gfs2: Revert 'Fix "truncate in progress" hang'
  gfs2: Add new go_held glock operation
  gfs2: Make go_instantiate take a glock
  gfs2: Use better variable name
  gfs2: List traversal in do_promote is safe
  Revert "gfs2: Stop using glock holder auto-demotion for now"

Bob Peterson (1):
  gfs2: do_promote glock holder stealing fix

 fs/gfs2/file.c       |  46 +++++++----
 fs/gfs2/glock.c      | 187 +++++++++++++++++--------------------------
 fs/gfs2/glock.h      |   2 +-
 fs/gfs2/glops.c      |  31 ++++---
 fs/gfs2/incore.h     |   6 +-
 fs/gfs2/main.c       |   1 -
 fs/gfs2/ops_fstype.c |   2 -
 fs/gfs2/quota.c      |  28 +------
 fs/gfs2/rgrp.c       |   3 +-
 fs/gfs2/rgrp.h       |   2 +-
 fs/gfs2/super.c      |   2 +-
 11 files changed, 126 insertions(+), 184 deletions(-)

-- 
2.35.1


             reply	other threads:[~2022-06-29 16:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-29 16:37 Andreas Gruenbacher [this message]
2022-06-29 16:37 ` [Cluster-devel] [PATCH 1/9] gfs2: Fix up gfs2_glock_async_wait Andreas Gruenbacher
2022-06-29 16:37 ` [Cluster-devel] [PATCH 2/9] gfs2: Instantiate glocks ouside of glock state engine Andreas Gruenbacher
2022-06-29 16:37 ` [Cluster-devel] [PATCH 3/9] gfs2: Revert 'Fix "truncate in progress" hang' Andreas Gruenbacher
2022-06-29 16:37 ` [Cluster-devel] [PATCH 4/9] gfs2: Add new go_held glock operation Andreas Gruenbacher
2022-06-29 16:37 ` [Cluster-devel] [PATCH 5/9] gfs2: Make go_instantiate take a glock Andreas Gruenbacher
2022-06-29 16:37 ` [Cluster-devel] [PATCH 6/9] gfs2: Use better variable name Andreas Gruenbacher
2022-06-29 16:37 ` [Cluster-devel] [PATCH 7/9] gfs2: do_promote glock holder stealing fix Andreas Gruenbacher
2022-06-29 16:37 ` [Cluster-devel] [PATCH 8/9] gfs2: List traversal in do_promote is safe Andreas Gruenbacher
2022-06-29 16:37 ` [Cluster-devel] [PATCH 9/9] Revert "gfs2: Stop using glock holder auto-demotion for now" Andreas Gruenbacher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220629163711.732931-1-agruenba@redhat.com \
    --to=agruenba@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).