From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Gruenbacher Date: Mon, 11 Jul 2022 12:27:47 +0200 Subject: [Cluster-devel] [PATCH 1/4] gfs2: stop using generic_writepages in gfs2_ail1_start_one In-Reply-To: <20220711041459.1062583-2-hch@lst.de> References: <20220711041459.1062583-2-hch@lst.de> Message-ID: <20220711102747.359525-1-agruenba@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Hello, On Mon, Jul 11, 2022 at 7:27 AM Christoph Hellwig wrote: > > Use filemap_fdatawrite_wbc instead of generic_writepages in > gfs2_ail1_start_one so that the functin can also cope with address_space > operations that only implement ->writepages and to properly account > for cgroup writeback. Reviewed-by: Andreas Gruenbacher I assume you want to push this through the xfs tree. Can you add the below follow-up cleanup? Thanks, Andreas --- fs/gfs2/log.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/gfs2/log.c b/fs/gfs2/log.c index 624dffc96136..7fc6cb95dec8 100644 --- a/fs/gfs2/log.c +++ b/fs/gfs2/log.c @@ -222,8 +222,7 @@ void gfs2_ail1_flush(struct gfs2_sbd *sdp, struct writeback_control *wbc) spin_unlock(&sdp->sd_ail_lock); blk_finish_plug(&plug); if (ret) { - gfs2_lm(sdp, "gfs2_ail1_start_one (generic_writepages) " - "returned: %d\n", ret); + gfs2_lm(sdp, "gfs2_ail1_start_one returned %d\n", ret); gfs2_withdraw(sdp); } trace_gfs2_ail_flush(sdp, wbc, 0); -- 2.36.1