cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 3/4] zonefs: remove ->writepage
Date: Tue, 19 Jul 2022 06:13:10 +0200	[thread overview]
Message-ID: <20220719041311.709250-4-hch@lst.de> (raw)
In-Reply-To: <20220719041311.709250-1-hch@lst.de>

->writepage is only used for single page writeback from memory reclaim,
and not called at all for cgroup writeback.  Follow the lead of XFS
and remove ->writepage and rely entirely on ->writepages.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Acked-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
---
 fs/zonefs/super.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/fs/zonefs/super.c b/fs/zonefs/super.c
index 053299758deb9..062c3f1da0327 100644
--- a/fs/zonefs/super.c
+++ b/fs/zonefs/super.c
@@ -232,13 +232,6 @@ static const struct iomap_writeback_ops zonefs_writeback_ops = {
 	.map_blocks		= zonefs_write_map_blocks,
 };
 
-static int zonefs_writepage(struct page *page, struct writeback_control *wbc)
-{
-	struct iomap_writepage_ctx wpc = { };
-
-	return iomap_writepage(page, wbc, &wpc, &zonefs_writeback_ops);
-}
-
 static int zonefs_writepages(struct address_space *mapping,
 			     struct writeback_control *wbc)
 {
@@ -266,7 +259,6 @@ static int zonefs_swap_activate(struct swap_info_struct *sis,
 static const struct address_space_operations zonefs_file_aops = {
 	.read_folio		= zonefs_read_folio,
 	.readahead		= zonefs_readahead,
-	.writepage		= zonefs_writepage,
 	.writepages		= zonefs_writepages,
 	.dirty_folio		= filemap_dirty_folio,
 	.release_folio		= iomap_release_folio,
-- 
2.30.2


  parent reply	other threads:[~2022-07-19  4:13 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-19  4:13 [Cluster-devel] remove iomap_writepage v2 Christoph Hellwig
2022-07-19  4:13 ` [Cluster-devel] [PATCH 1/4] gfs2: stop using generic_writepages in gfs2_ail1_start_one Christoph Hellwig
2023-01-18 21:22   ` Andreas Gruenbacher
2023-01-19  6:22     ` Christoph Hellwig
2022-07-19  4:13 ` [Cluster-devel] [PATCH 2/4] gfs2: remove ->writepage Christoph Hellwig
2022-07-19  4:13 ` Christoph Hellwig [this message]
2022-07-19  6:56   ` [Cluster-devel] [PATCH 3/4] zonefs: " Chaitanya Kulkarni
2022-07-19  4:13 ` [Cluster-devel] [PATCH 4/4] iomap: remove iomap_writepage Christoph Hellwig
2022-07-19  6:56   ` Chaitanya Kulkarni
2022-07-22 17:56   ` Darrick J. Wong
2022-07-28 11:10 ` [Cluster-devel] remove iomap_writepage v2 Jan Kara
2022-07-28 14:18   ` Matthew Wilcox
2022-07-28 22:48     ` Dave Chinner
2022-07-28 23:26       ` Yang Shi
2022-07-29  9:22   ` Mel Gorman
2022-07-29 14:11     ` Christoph Hellwig
2022-08-01 15:31       ` Johannes Weiner
2022-08-10 20:43         ` Matthew Wilcox
2022-08-10 21:32           ` Andreas Grünbacher
2022-08-10 23:17             ` Matthew Wilcox
2022-08-11  5:58           ` Christoph Hellwig
  -- strict thread matches above, loose matches on Subject: below --
2022-07-11  4:14 [Cluster-devel] remove iomap_writepage Christoph Hellwig
2022-07-11  4:14 ` [Cluster-devel] [PATCH 3/4] zonefs: remove ->writepage Christoph Hellwig
2022-07-11  4:47   ` Damien Le Moal
2022-07-11  9:12   ` Johannes Thumshirn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220719041311.709250-4-hch@lst.de \
    --to=hch@lst.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).