From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Date: Fri, 29 Jul 2022 16:11:45 +0200 Subject: [Cluster-devel] remove iomap_writepage v2 In-Reply-To: <20220729092216.GE3493@suse.de> References: <20220719041311.709250-1-hch@lst.de> <20220728111016.uwbaywprzkzne7ib@quack3> <20220729092216.GE3493@suse.de> Message-ID: <20220729141145.GA31605@lst.de> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Fri, Jul 29, 2022 at 10:22:16AM +0100, Mel Gorman wrote: > There is some context missing because it's not clear what the full impact is > but it is definitly the case that writepage is ignored in some contexts for > common filesystems so lets assume that writepage from reclaim context always > failed as a worst case scenario. Certainly this type of change is something > linux-mm needs to be aware of because we've been blind-sided before. Between willy and Johannes pushing or it I was under the strong assumption that linux-mm knows of it.. > I don't think it would be incredibly damaging although there *might* be > issues with small systems or cgroups. Johannes specifically mentioned that cgroup writeback will never call into ->writepage anyway.