From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kara Date: Thu, 1 Sep 2022 17:47:38 +0200 Subject: [Cluster-devel] [PATCH v2 07/14] ntfs3: replace ll_rw_block() In-Reply-To: <20220901133505.2510834-8-yi.zhang@huawei.com> References: <20220901133505.2510834-1-yi.zhang@huawei.com> <20220901133505.2510834-8-yi.zhang@huawei.com> Message-ID: <20220901154738.6b5gti2w2y2f4see@quack3> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Thu 01-09-22 21:34:58, Zhang Yi wrote: > ll_rw_block() is not safe for the sync read path because it cannot > guarantee that submitting read IO if the buffer has been locked. We > could get false positive EIO after wait_on_buffer() if the buffer has > been locked by others. So stop using ll_rw_block() in > ntfs_get_block_vbo(). > > Signed-off-by: Zhang Yi Looks good. Feel free to add: Reviewed-by: Jan Kara Honza > --- > fs/ntfs3/inode.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/fs/ntfs3/inode.c b/fs/ntfs3/inode.c > index 51363d4e8636..cadbfa111539 100644 > --- a/fs/ntfs3/inode.c > +++ b/fs/ntfs3/inode.c > @@ -630,12 +630,9 @@ static noinline int ntfs_get_block_vbo(struct inode *inode, u64 vbo, > bh->b_size = block_size; > off = vbo & (PAGE_SIZE - 1); > set_bh_page(bh, page, off); > - ll_rw_block(REQ_OP_READ, 1, &bh); > - wait_on_buffer(bh); > - if (!buffer_uptodate(bh)) { > - err = -EIO; > + err = bh_read(bh, 0); > + if (err < 0) > goto out; > - } > zero_user_segment(page, off + voff, off + block_size); > } > } > -- > 2.31.1 > -- Jan Kara SUSE Labs, CR