cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
* [Cluster-devel] [PATCH -next] fs: dlm: Fix build error without DEBUG_LOCK_ALLOC
@ 2022-11-23  6:53 Zheng Yongjun
  2022-11-23 13:39 ` Alexander Aring
                   ` (3 more replies)
  0 siblings, 4 replies; 6+ messages in thread
From: Zheng Yongjun @ 2022-11-23  6:53 UTC (permalink / raw)
  To: cluster-devel.redhat.com

If CONFIG_DLM is y, DEBUG_LOCK_ALLOC is n, building fails:

fs/dlm/lowcomms.o: In function `lowcomms_queue_rwork':
lowcomms.c:(.text+0x2ac): undefined reference to `lockdep_is_held'
lowcomms.c:(.text+0x308): undefined reference to `lockdep_is_held'
fs/dlm/lowcomms.o: In function `lowcomms_queue_swork':
lowcomms.c:(.text+0x3e0): undefined reference to `lockdep_is_held'
fs/dlm/lowcomms.o: In function `restore_callbacks':
lowcomms.c:(.text+0xd8c): undefined reference to `lockdep_is_held'
lowcomms.c:(.text+0xdcc): undefined reference to `lockdep_is_held'

Make DLM select DEBUG_LOCK_ALLOC to fix this.

Fixes: dbb751ffab0b ("fs: dlm: parallelize lowcomms socket handling")
Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
---
 fs/dlm/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/dlm/Kconfig b/fs/dlm/Kconfig
index 1105ce3c80cb..90a0861e7a29 100644
--- a/fs/dlm/Kconfig
+++ b/fs/dlm/Kconfig
@@ -5,6 +5,7 @@ menuconfig DLM
 	depends on SYSFS && CONFIGFS_FS && (IPV6 || IPV6=n)
 	select IP_SCTP
 	select SRCU
+	select DEBUG_LOCK_ALLOC
 	help
 	A general purpose distributed lock manager for kernel or userspace
 	applications.
--
2.17.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2022-11-29  3:05 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-23  6:53 [Cluster-devel] [PATCH -next] fs: dlm: Fix build error without DEBUG_LOCK_ALLOC Zheng Yongjun
2022-11-23 13:39 ` Alexander Aring
2022-11-23 13:49   ` Alexander Aring
2022-11-25 14:34 ` kernel test robot
2022-11-27 11:11 ` kernel test robot
2022-11-29  3:05 ` kernel test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).