cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Alexander Aring <aahringo@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH dlm/next 3/7] fs: dlm: be sure to call dlm_send_queue_flush()
Date: Thu, 12 Jan 2023 17:10:33 -0500	[thread overview]
Message-ID: <20230112221037.1882548-3-aahringo@redhat.com> (raw)
In-Reply-To: <20230112221037.1882548-1-aahringo@redhat.com>

If we release a midcomms node structure there should be nothing left
inside the dlm midcomms send queue. However sometimes we have this case
because I believe some DLM_FIN message didn't got acked... if we run
into a timeout handling then we should be sure there is no pending send
dlm message inside this queue when releasing midcomms node structure.

Cc: stable at vger.kernel.org
Fixes: 489d8e559c65 ("fs: dlm: add reliable connection if reconnect")
Signed-off-by: Alexander Aring <aahringo@redhat.com>
---
 fs/dlm/midcomms.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/dlm/midcomms.c b/fs/dlm/midcomms.c
index 2e60d9a2c883..a3eb19c8cec5 100644
--- a/fs/dlm/midcomms.c
+++ b/fs/dlm/midcomms.c
@@ -1402,6 +1402,7 @@ static void midcomms_node_release(struct rcu_head *rcu)
 	struct midcomms_node *node = container_of(rcu, struct midcomms_node, rcu);
 
 	WARN_ON_ONCE(atomic_read(&node->send_queue_cnt));
+	dlm_send_queue_flush(node);
 	kfree(node);
 }
 
-- 
2.31.1


  parent reply	other threads:[~2023-01-12 22:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-12 22:10 [Cluster-devel] [PATCH dlm/next 1/7] fs: dlm: start first midcomms then scand Alexander Aring
2023-01-12 22:10 ` [Cluster-devel] [PATCH dlm/next 2/7] fs: dlm: fix use after free in midcomms commit Alexander Aring
2023-01-12 22:10 ` Alexander Aring [this message]
2023-01-12 22:10 ` [Cluster-devel] [PATCH dlm/next 4/7] fs: dlm: fix race setting stop tx flag Alexander Aring
2023-01-12 22:10 ` [Cluster-devel] [PATCH dlm/next 5/7] fs: dlm: don't set stop rx flag after node reset Alexander Aring
2023-01-12 22:10 ` [Cluster-devel] [PATCH dlm/next 6/7] fs: dlm: move sending fin message into state change handling Alexander Aring
2023-01-12 22:10 ` [Cluster-devel] [PATCH dlm/next 7/7] fs: dlm: send FIN ack back in right cases Alexander Aring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230112221037.1882548-3-aahringo@redhat.com \
    --to=aahringo@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).