From: Alexander Aring <aahringo@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH dlm/next 5/8] fs: dlm: reduce the timeout time to 5 secs
Date: Thu, 12 Jan 2023 17:18:46 -0500 [thread overview]
Message-ID: <20230112221849.1883104-6-aahringo@redhat.com> (raw)
In-Reply-To: <20230112221849.1883104-1-aahringo@redhat.com>
When a shutdown stucks for any reason we switch to a 5 secs timeout
instead of getting stucked for a long time and even HUNG_TASK reports
about stucking into the wait_event_timeout() handling. In 5 secs it
should already be done in most of all cases, if not we timeout and try
to force a shutdown.
Signed-off-by: Alexander Aring <aahringo@redhat.com>
---
fs/dlm/midcomms.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/dlm/midcomms.c b/fs/dlm/midcomms.c
index cf91a5a11b4f..3932c7cf0e7a 100644
--- a/fs/dlm/midcomms.c
+++ b/fs/dlm/midcomms.c
@@ -147,7 +147,7 @@
/* init value for sequence numbers for testing purpose only e.g. overflows */
#define DLM_SEQ_INIT 0
/* 3 minutes wait to sync ending of dlm */
-#define DLM_SHUTDOWN_TIMEOUT msecs_to_jiffies(3 * 60 * 1000)
+#define DLM_SHUTDOWN_TIMEOUT msecs_to_jiffies(5000)
#define DLM_VERSION_NOT_SET 0
struct midcomms_node {
--
2.31.1
next prev parent reply other threads:[~2023-01-12 22:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-12 22:18 [Cluster-devel] [PATCH dlm/next 0/8] fs: dlm: better handling for new stop/start testcase Alexander Aring
2023-01-12 22:18 ` [Cluster-devel] [PATCH dlm/next 1/8] fs: dlm: bring back previously shutdown handling Alexander Aring
2023-01-12 22:18 ` [Cluster-devel] [PATCH dlm/next 2/8] fs: dlm: change to ignore unexpected non dlm opts msgs Alexander Aring
2023-01-12 22:18 ` [Cluster-devel] [PATCH dlm/next 3/8] fs: dlm: wait until all midcomms nodes detects version Alexander Aring
2023-01-12 22:18 ` [Cluster-devel] [PATCH dlm/next 4/8] fs: dlm: make dlm sequence id handling more robust Alexander Aring
2023-01-12 22:18 ` Alexander Aring [this message]
2023-01-12 22:18 ` [Cluster-devel] [PATCH dlm/next 6/8] fs: dlm: remove newline in log_print Alexander Aring
2023-01-12 22:18 ` [Cluster-devel] [PATCH dlm/next 7/8] fs: dlm: move state change into else branch Alexander Aring
2023-01-12 22:18 ` [Cluster-devel] [PATCH dlm/next 8/8] fs: dlm: remove unnecessary waker_up() calls Alexander Aring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230112221849.1883104-6-aahringo@redhat.com \
--to=aahringo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).