cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Al Viro <viro@zeniv.linux.org.uk>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH v3 2/6] erofs: convert to use i_blockmask()
Date: Fri, 10 Mar 2023 03:15:47 +0000	[thread overview]
Message-ID: <20230310031547.GD3390869@ZenIV> (raw)
In-Reply-To: <20230309152127.41427-2-frank.li@vivo.com>

On Thu, Mar 09, 2023 at 11:21:23PM +0800, Yangtao Li wrote:
> Use i_blockmask() to simplify code.

Umm...  What's the branchpoint for that series?  Not the mainline -
there we have i_blocksize() open-coded...

> Signed-off-by: Yangtao Li <frank.li@vivo.com>
> ---
> v3:
> -none
> v2:
> -convert to i_blockmask()
>  fs/erofs/data.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/erofs/data.c b/fs/erofs/data.c
> index 7e8baf56faa5..e9d1869cd4b3 100644
> --- a/fs/erofs/data.c
> +++ b/fs/erofs/data.c
> @@ -380,7 +380,7 @@ static ssize_t erofs_file_read_iter(struct kiocb *iocb, struct iov_iter *to)
>  		if (bdev)
>  			blksize_mask = bdev_logical_block_size(bdev) - 1;
>  		else
> -			blksize_mask = i_blocksize(inode) - 1;
> +			blksize_mask = i_blockmask(inode);
>  
>  		if ((iocb->ki_pos | iov_iter_count(to) |
>  		     iov_iter_alignment(to)) & blksize_mask)
> -- 
> 2.25.1
> 


  reply	other threads:[~2023-03-10  3:15 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-09 15:21 [Cluster-devel] [PATCH v3 1/6] fs: add i_blockmask() Yangtao Li
2023-03-09 15:21 ` [Cluster-devel] [PATCH v3 2/6] erofs: convert to use i_blockmask() Yangtao Li
2023-03-10  3:15   ` Al Viro [this message]
2023-03-10  3:42     ` Gao Xiang
2023-03-10  3:47       ` Gao Xiang
2023-03-10  3:51     ` [Cluster-devel] " Yangtao Li
2023-03-10  4:05       ` Al Viro
2023-03-10  6:50         ` Yangtao Li
2023-03-09 15:21 ` [Cluster-devel] [PATCH v3 3/6] gfs2: " Yangtao Li
2023-03-09 15:21 ` [Cluster-devel] [PATCH v3 4/6] ext4: " Yangtao Li
2023-03-10  3:19   ` Al Viro
2023-03-10  3:32     ` Al Viro
2023-03-09 15:21 ` [Cluster-devel] [PATCH v3 5/6] ocfs2: " Yangtao Li
2023-03-10  3:26   ` Al Viro
2023-03-09 15:21 ` [Cluster-devel] [PATCH v3 6/6] fs/remap_range: " Yangtao Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230310031547.GD3390869@ZenIV \
    --to=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).