From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Date: Tue, 28 Mar 2023 16:04:33 -0700 Subject: [Cluster-devel] return an ERR_PTR from __filemap_get_folio v2 In-Reply-To: <20230121065755.1140136-1-hch@lst.de> References: <20230121065755.1140136-1-hch@lst.de> Message-ID: <20230328160433.4f3dc32b480239bce9e2f9ef@linux-foundation.org> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Sat, 21 Jan 2023 07:57:48 +0100 Christoph Hellwig wrote: > __filemap_get_folio and its wrappers can return NULL for three different > conditions, which in some cases requires the caller to reverse engineer > the decision making. This is fixed by returning an ERR_PTR instead of > NULL and thus transporting the reason for the failure. But to make > that work we first need to ensure that no xa_value special case is > returned and thus return the FGP_ENTRY flag. It turns out that flag > is barely used and can usually be deal with in a better way. > > Note that the shmem patches in here are non-trivial and need some > careful review and testing. How are we going with the review and testing. I assume that we're now OK on the runtime testing front, but do you feel that review has been adequate? Thanks.