From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Date: Mon, 3 Apr 2023 15:27:11 +0200 Subject: [Cluster-devel] [PATCH v2 4.19/5.4/5.10 1/1] gfs2: Always check inode size of inline inodes In-Reply-To: <20230324202615.330615-1-pchelkin@ispras.ru> References: <20230324201933.329885-2-pchelkin@ispras.ru> <20230324202615.330615-1-pchelkin@ispras.ru> Message-ID: <2023040302-surface-thwarting-037f@gregkh> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Fri, Mar 24, 2023 at 11:26:15PM +0300, Fedor Pchelkin wrote: > From: Andreas Gruenbacher > > commit 70376c7ff31221f1d21db5611d8209e677781d3a upstream. > > Check if the inode size of stuffed (inline) inodes is within the allowed > range when reading inodes from disk (gfs2_dinode_in()). This prevents > us from on-disk corruption. > > The two checks in stuffed_readpage() and gfs2_unstuffer_page() that just > truncate inline data to the maximum allowed size don't actually make > sense, and they can be removed now as well. > > Reported-by: syzbot+7bb81dfa9cda07d9cd9d at syzkaller.appspotmail.com > Signed-off-by: Andreas Gruenbacher > [pchelkin at ispras.ru: adjust the inode variable inside gfs2_dinode_in with > the format used before upstream commit 7db354444ad8 ("gfs2: Cosmetic > gfs2_dinode_{in,out} cleanup")] > Signed-off-by: Fedor Pchelkin > --- > v2: add missed From: tag Now queued up, thanks. greg k-h