cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Johannes Thumshirn <jth@kernel.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH v3 14/19] floppy: use __bio_add_page for adding single page to bio
Date: Wed, 19 Apr 2023 16:09:24 +0200	[thread overview]
Message-ID: <20230419140929.5924-15-jth@kernel.org> (raw)
In-Reply-To: <20230419140929.5924-1-jth@kernel.org>

From: Johannes Thumshirn <johannes.thumshirn@wdc.com>

The floppy code uses bio_add_page() to add a page to a newly created bio.
bio_add_page() can fail, but the return value is never checked.

Use __bio_add_page() as adding a single page to a newly created bio is
guaranteed to succeed.

This brings us a step closer to marking bio_add_page() as __must_check.

Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
---
 drivers/block/floppy.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c
index 487840e3564d..6f46a30f7c36 100644
--- a/drivers/block/floppy.c
+++ b/drivers/block/floppy.c
@@ -4147,7 +4147,7 @@ static int __floppy_read_block_0(struct block_device *bdev, int drive)
 	cbdata.drive = drive;
 
 	bio_init(&bio, bdev, &bio_vec, 1, REQ_OP_READ);
-	bio_add_page(&bio, page, block_size(bdev), 0);
+	__bio_add_page(&bio, page, block_size(bdev), 0);
 
 	bio.bi_iter.bi_sector = 0;
 	bio.bi_flags |= (1 << BIO_QUIET);
-- 
2.39.2


  parent reply	other threads:[~2023-04-19 14:09 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-19 14:09 [Cluster-devel] [PATCH v3 00/19] bio: check return values of bio_add_page Johannes Thumshirn
2023-04-19 14:09 ` [Cluster-devel] [PATCH v3 01/19] swap: use __bio_add_page to add page to bio Johannes Thumshirn
2023-04-19 14:09 ` [Cluster-devel] [PATCH v3 02/19] drbd: " Johannes Thumshirn
2023-04-19 14:09 ` [Cluster-devel] [PATCH v3 03/19] dm: dm-zoned: use __bio_add_page for adding single metadata page Johannes Thumshirn
2023-04-19 14:09 ` [Cluster-devel] [PATCH v3 04/19] fs: buffer: use __bio_add_page to add single page to bio Johannes Thumshirn
2023-04-19 14:09 ` [Cluster-devel] [PATCH v3 05/19] md: use __bio_add_page to add single page Johannes Thumshirn
2023-04-19 14:09 ` [Cluster-devel] [PATCH v3 06/19] md: raid5-log: " Johannes Thumshirn
2023-04-19 14:09 ` [Cluster-devel] [PATCH v3 07/19] md: raid5: use __bio_add_page to add single page to new bio Johannes Thumshirn
2023-04-19 14:09 ` [Cluster-devel] [PATCH v3 08/19] btrfs: repair: use __bio_add_page for adding single page Johannes Thumshirn
2023-04-19 14:09 ` [Cluster-devel] [PATCH v3 09/19] btrfs: raid56: use __bio_add_page to add " Johannes Thumshirn
2023-04-19 14:09 ` [Cluster-devel] [PATCH v3 10/19] jfs: logmgr: use __bio_add_page to add single page to bio Johannes Thumshirn
2023-04-19 14:09 ` [Cluster-devel] [PATCH v3 11/19] gfs: use __bio_add_page for adding " Johannes Thumshirn
2023-04-19 15:19   ` Andreas Gruenbacher
2023-04-20  8:55     ` Johannes Thumshirn
2023-04-19 14:09 ` [Cluster-devel] [PATCH v3 12/19] zonefs: " Johannes Thumshirn
2023-04-19 14:09 ` [Cluster-devel] [PATCH v3 13/19] zram: " Johannes Thumshirn
2023-04-19 14:09 ` Johannes Thumshirn [this message]
2023-04-19 14:09 ` [Cluster-devel] [PATCH v3 15/19] md: check for failure when adding pages in alloc_behind_master_bio Johannes Thumshirn
2023-04-19 14:09 ` [Cluster-devel] [PATCH v3 16/19] md: raid1: use __bio_add_page for adding single page to bio Johannes Thumshirn
2023-04-19 14:09 ` [Cluster-devel] [PATCH v3 17/19] md: raid1: check if adding pages to resync bio fails Johannes Thumshirn
2023-04-20  4:39   ` Song Liu
2023-04-19 14:09 ` [Cluster-devel] [PATCH v3 18/19] dm-crypt: check if adding pages to clone " Johannes Thumshirn
2023-04-19 14:09 ` [Cluster-devel] [PATCH v3 19/19] block: mark bio_add_page as __must_check Johannes Thumshirn
2023-04-19 14:19   ` Matthew Wilcox
2023-04-19 15:49     ` Johannes Thumshirn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230419140929.5924-15-jth@kernel.org \
    --to=jth@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).