From: Johannes Thumshirn <jth@kernel.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH v4 12/22] zonefs: use __bio_add_page for adding single page to bio
Date: Thu, 20 Apr 2023 12:04:51 +0200 [thread overview]
Message-ID: <20230420100501.32981-13-jth@kernel.org> (raw)
In-Reply-To: <20230420100501.32981-1-jth@kernel.org>
From: Johannes Thumshirn <johannes.thumshirn@wdc.com>
The zonefs superblock reading code uses bio_add_page() to add a page to a
newly created bio. bio_add_page() can fail, but the return value is
never checked.
Use __bio_add_page() as adding a single page to a newly created bio is
guaranteed to succeed.
This brings us a step closer to marking bio_add_page() as __must_check.
Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Acked-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
---
fs/zonefs/super.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/zonefs/super.c b/fs/zonefs/super.c
index 23b8b299c64e..9350221abfc5 100644
--- a/fs/zonefs/super.c
+++ b/fs/zonefs/super.c
@@ -1128,7 +1128,7 @@ static int zonefs_read_super(struct super_block *sb)
bio_init(&bio, sb->s_bdev, &bio_vec, 1, REQ_OP_READ);
bio.bi_iter.bi_sector = 0;
- bio_add_page(&bio, page, PAGE_SIZE, 0);
+ __bio_add_page(&bio, page, PAGE_SIZE, 0);
ret = submit_bio_wait(&bio);
if (ret)
--
2.39.2
next prev parent reply other threads:[~2023-04-20 10:04 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-20 10:04 [Cluster-devel] [PATCH v4 00/22] bio: check return values of bio_add_page Johannes Thumshirn
2023-04-20 10:04 ` [Cluster-devel] [PATCH v4 01/22] swap: use __bio_add_page to add page to bio Johannes Thumshirn
2023-04-20 10:04 ` [Cluster-devel] [PATCH v4 02/22] drbd: " Johannes Thumshirn
2023-04-20 10:04 ` [Cluster-devel] [PATCH v4 03/22] dm: dm-zoned: use __bio_add_page for adding single metadata page Johannes Thumshirn
2023-04-20 10:04 ` [Cluster-devel] [PATCH v4 04/22] fs: buffer: use __bio_add_page to add single page to bio Johannes Thumshirn
2023-04-20 10:04 ` [Cluster-devel] [PATCH v4 05/22] md: use __bio_add_page to add single page Johannes Thumshirn
2023-04-20 10:04 ` [Cluster-devel] [PATCH v4 06/22] md: raid5-log: " Johannes Thumshirn
2023-04-20 10:04 ` [Cluster-devel] [PATCH v4 07/22] md: raid5: use __bio_add_page to add single page to new bio Johannes Thumshirn
2023-04-20 10:04 ` [Cluster-devel] [PATCH v4 08/22] btrfs: repair: use __bio_add_page for adding single page Johannes Thumshirn
2023-04-20 10:04 ` [Cluster-devel] [PATCH v4 09/22] btrfs: raid56: use __bio_add_page to add " Johannes Thumshirn
2023-04-20 10:04 ` [Cluster-devel] [PATCH v4 10/22] jfs: logmgr: use __bio_add_page to add single page to bio Johannes Thumshirn
2023-04-20 10:04 ` [Cluster-devel] [PATCH v4 11/22] gfs2: use __bio_add_page for adding " Johannes Thumshirn
2023-04-20 10:04 ` Johannes Thumshirn [this message]
2023-04-20 10:04 ` [Cluster-devel] [PATCH v4 13/22] zram: " Johannes Thumshirn
2023-04-21 6:57 ` Sergey Senozhatsky
2023-04-20 10:04 ` [Cluster-devel] [PATCH v4 14/22] floppy: " Johannes Thumshirn
2023-04-20 10:04 ` [Cluster-devel] [PATCH v4 15/22] md: check for failure when adding pages in alloc_behind_master_bio Johannes Thumshirn
2023-04-20 10:04 ` [Cluster-devel] [PATCH v4 16/22] md: raid1: use __bio_add_page for adding single page to bio Johannes Thumshirn
2023-04-20 10:04 ` [Cluster-devel] [PATCH v4 17/22] md: raid1: check if adding pages to resync bio fails Johannes Thumshirn
2023-04-20 10:04 ` [Cluster-devel] [PATCH v4 18/22] dm-crypt: check if adding pages to clone " Johannes Thumshirn
2023-04-20 10:04 ` [Cluster-devel] [PATCH v4 19/22] block: mark bio_add_page as __must_check Johannes Thumshirn
2023-04-20 10:04 ` [Cluster-devel] [PATCH v4 20/22] block: add __bio_add_folio Johannes Thumshirn
2023-04-20 10:05 ` [Cluster-devel] [PATCH v4 21/22] fs: iomap: use __bio_add_folio where possible Johannes Thumshirn
2023-04-20 10:05 ` [Cluster-devel] [PATCH v4 22/22] block: mark bio_add_folio as __must_check Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230420100501.32981-13-jth@kernel.org \
--to=jth@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).