From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergey Senozhatsky Date: Fri, 21 Apr 2023 15:57:47 +0900 Subject: [Cluster-devel] [PATCH v4 13/22] zram: use __bio_add_page for adding single page to bio In-Reply-To: <20230420100501.32981-14-jth@kernel.org> References: <20230420100501.32981-1-jth@kernel.org> <20230420100501.32981-14-jth@kernel.org> Message-ID: <20230421065747.GB1496740@google.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit + Minchan On (23/04/20 12:04), Johannes Thumshirn wrote: > > From: Johannes Thumshirn > > The zram writeback code uses bio_add_page() to add a page to a newly > created bio. bio_add_page() can fail, but the return value is never > checked. > > Use __bio_add_page() as adding a single page to a newly created bio is > guaranteed to succeed. > > This brings us a step closer to marking bio_add_page() as __must_check. > > Signed-off-by: Johannes Thumshirn > Reviewed-by: Damien Le Moal Reviewed-by: Sergey Senozhatsky